Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass tenures ForecastParameters instead of just children #79

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

zz-hh-aa
Copy link
Collaborator

What does this PR do?

  • Passes ForecastParameters to the tenure classes as well as Household, instead of just a few of its properties
  • Recreates an older PR on a new branch (the old one got too messy after a rebase)

Closes #52

@zz-hh-aa zz-hh-aa requested a review from a team August 30, 2024 15:00
Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fairhold-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 3:26pm

Copy link
Collaborator

@gabrielegranello gabrielegranello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, looks tidier thank you @zz-hh-aa

@zz-hh-aa zz-hh-aa merged commit fd5d5ee into main Oct 4, 2024
3 checks passed
@zz-hh-aa zz-hh-aa deleted the oz/pass-forecast-param-2 branch October 4, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

types: Can we share ForecastParameters instead of just some children?
2 participants