Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor lifetime type #78

Merged
merged 7 commits into from
Sep 3, 2024
Merged

feat: refactor lifetime type #78

merged 7 commits into from
Sep 3, 2024

Conversation

zz-hh-aa
Copy link
Collaborator

What does this PR do?

  • Creates a new Lifetime class which performs all lifetime-related calculations
    • I thought this was neater than sharing a single type with optional properties as the issue originally laid out, as there were various instances of repeated properties and more instances of Lifetime than were necessary. Now there is one instance of lifetime which has one instance of each relevant property.
  • Updates the relevant graph wrappers to take the new data structure

Closes #66

Screenshot 2024-08-27 151358
Screenshot 2024-08-27 151414

@vercel Vercel
Copy link

vercel bot commented Aug 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fairhold-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 10:02pm

@zz-hh-aa zz-hh-aa requested a review from a team August 27, 2024 14:17
@zz-hh-aa zz-hh-aa marked this pull request as ready for review August 27, 2024 14:17
gabrielegranello
gabrielegranello approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@gabrielegranello gabrielegranello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Looks good to me

@zz-hh-aa zz-hh-aa force-pushed the oz/refactor-lifetime branch from 53f17d3 to 18e1fd1 Compare September 3, 2024 22:00
@zz-hh-aa zz-hh-aa merged commit 6907c0f into main Sep 3, 2024
3 checks passed
@zz-hh-aa zz-hh-aa deleted the oz/refactor-lifetime branch September 3, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielegranello gabrielegranello gabrielegranello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Share and refactor Lifetime type
2 participants
@zz-hh-aa @gabrielegranello