Prefix support #1498

SutuSebastian · 2024-10-11T17:21:19Z

Description

Bring tailwindCSS prefix support and optimise the way tailwindCSS scans for flowbite-react classname's.
Simplify setup process requiring only a single tailwindCSS plugin.

Changes

[ ]

Result

Before

After

Issues

#339, #1286, #1389, #1454, #1473, #1489

…post build and prefixer

changeset-bot · 2024-10-11T17:21:22Z

⚠️ No Changeset found

Latest commit: de5450b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-10-11T17:21:22Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
flowbite-react	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 29, 2024 0:31am
flowbite-react-storybook	❌ Failed (Inspect)			Oct 29, 2024 0:31am

…lasslist for each component using AST fix: `popoverTheme` missing `createTheme()` wrapper lacking formatting, linting and intellisense

- remove redundant packages - expose all tailwindcss plugins and data to import paths - move tailwind.ts into its own directory and split logic into multiple files - simplify `new Glob()` usage

coderabbitai · 2024-10-25T15:47:33Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

- do nothing if className is empty - do nothing if its already prefixed

- replace `twMerge` imports

- trim `prefix` before applying

feat: first prefix support implementation with class list generation …

02b6a4d

…post build and prefixer

SutuSebastian added the 🚀 enhancement New feature or request label Oct 11, 2024

SutuSebastian self-assigned this Oct 11, 2024

vercel bot deployed to Preview – flowbite-react October 11, 2024 17:22 View deployment

chore: drop tailwindcss-patch in favor of manual search and parse c…

347b8ae

…lasslist for each component using AST fix: `popoverTheme` missing `createTheme()` wrapper lacking formatting, linting and intellisense

vercel bot deployed to Preview – flowbite-react-storybook October 14, 2024 13:09 View deployment

vercel bot deployed to Preview – flowbite-react October 14, 2024 13:11 View deployment

SutuSebastian added 2 commits October 14, 2024 16:48

convert class-list.json to class-list.ts`

9617f96

sort CLASS_LIST_MAP

05217ac

vercel bot deployed to Preview – flowbite-react October 14, 2024 13:56 View deployment

vercel bot deployed to Preview – flowbite-react-storybook October 14, 2024 13:57 View deployment

cleanup:

a3c4e14

- remove redundant packages - expose all tailwindcss plugins and data to import paths - move tailwind.ts into its own directory and split logic into multiple files - simplify `new Glob()` usage

vercel bot had a problem deploying to Preview – flowbite-react October 15, 2024 08:29 Failure

vercel bot deployed to Preview – flowbite-react-storybook October 15, 2024 08:30 View deployment

fix theme extend values

7781fbd

vercel bot deployed to Preview – flowbite-react-storybook October 15, 2024 08:31 View deployment

vercel bot had a problem deploying to Preview – flowbite-react October 15, 2024 08:32 Failure

SutuSebastian added 2 commits October 15, 2024 11:44

fix storybook darkMode to be class

c7ce9e5

remove flowbite/plugin

a0766af

vercel bot had a problem deploying to Preview – flowbite-react October 15, 2024 08:46 Failure

vercel bot deployed to Preview – flowbite-react-storybook October 15, 2024 08:47 View deployment

SutuSebastian added 2 commits October 15, 2024 12:09

extend theme instead of override

9c66a31

format

aaca7fc

vercel bot deployed to Preview – flowbite-react October 15, 2024 09:12 View deployment

vercel bot deployed to Preview – flowbite-react-storybook October 15, 2024 09:13 View deployment

expose helpers and hooks too

21256d3

vercel bot deployed to Preview – flowbite-react-storybook October 15, 2024 09:42 View deployment

vercel bot deployed to Preview – flowbite-react October 15, 2024 09:43 View deployment

remove unused import

297e064

vercel bot deployed to Preview – flowbite-react October 22, 2024 08:22 View deployment

vercel bot deployed to Preview – flowbite-react-storybook October 22, 2024 08:22 View deployment

rework theming system and add prefix on-the-fly -- [UNSTABLE]

c41ea1e

vercel bot had a problem deploying to Preview – flowbite-react-storybook October 25, 2024 15:47 Failure

vercel bot deployed to Preview – flowbite-react October 25, 2024 15:49 View deployment

SutuSebastian added 2 commits October 26, 2024 13:38

enhance applyPrefix

7832e11

- do nothing if className is empty - do nothing if its already prefixed

fix derp reversed if-else

e08d74a

vercel bot had a problem deploying to Preview – flowbite-react-storybook October 26, 2024 10:38 Failure

vercel bot deployed to Preview – flowbite-react October 26, 2024 10:40 View deployment

simplify resolveTheme

f8918c9

vercel bot had a problem deploying to Preview – flowbite-react October 26, 2024 16:48 Failure

vercel bot had a problem deploying to Preview – flowbite-react-storybook October 26, 2024 16:49 Failure

SutuSebastian added 2 commits October 26, 2024 20:00

remove unused import

d739163

implement twMerge proxy with prefix provided from getStore()

3c722bf

- replace `twMerge` imports

vercel bot deployed to Preview – flowbite-react October 27, 2024 07:38 View deployment

vercel bot had a problem deploying to Preview – flowbite-react-storybook October 27, 2024 07:38 Failure

SutuSebastian added 2 commits October 28, 2024 18:34

up some packages; clean next.config.js

e23c2e3

deeply merge theme objects (from store or props) using twMerge

678638c

- trim `prefix` before applying

vercel bot had a problem deploying to Preview – flowbite-react-storybook October 28, 2024 16:37 Failure

vercel bot deployed to Preview – flowbite-react October 28, 2024 16:40 View deployment

resolve unique values

c3bd201

vercel bot had a problem deploying to Preview – flowbite-react-storybook October 29, 2024 10:59 Failure

vercel bot deployed to Preview – flowbite-react October 29, 2024 11:01 View deployment

resolve deepMergeStrings unique values

de5450b

vercel bot had a problem deploying to Preview – flowbite-react-storybook October 29, 2024 12:30 Failure

vercel bot deployed to Preview – flowbite-react October 29, 2024 12:31 View deployment

SutuSebastian mentioned this pull request Nov 7, 2024

Theme briefly flashes light mode #1506

Open

2 tasks

SutuSebastian mentioned this pull request Nov 22, 2024

No force setting a cookie in localStorage when theme mode stays at default #1512

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prefix support #1498

Prefix support #1498

SutuSebastian commented Oct 11, 2024 •

edited

Loading

changeset-bot bot commented Oct 11, 2024 •

edited

Loading

vercel bot commented Oct 11, 2024 •

edited

Loading

coderabbitai bot commented Oct 25, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Prefix support #1498

Are you sure you want to change the base?

Prefix support #1498

Conversation

SutuSebastian commented Oct 11, 2024 • edited Loading

Description

Changes

Result

Issues

changeset-bot bot commented Oct 11, 2024 • edited Loading

⚠️ No Changeset found

vercel bot commented Oct 11, 2024 • edited Loading

coderabbitai bot commented Oct 25, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

SutuSebastian commented Oct 11, 2024 •

edited

Loading

changeset-bot bot commented Oct 11, 2024 •

edited

Loading

vercel bot commented Oct 11, 2024 •

edited

Loading

coderabbitai bot commented Oct 25, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)