-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to Intern 3.0.0 #25
Conversation
Demonstrates that this new version hangs when executed against PhantomJS/Selenium
@csnover does I3 support PhantomJS or was that dropped? |
It's still in the documentation and pretends like it'll work, so I suspect removing it was not the intention. |
The issue may be that the intern config doesn't specify |
That does indeed appear to be the issue in this case, @jason0x43. Unfortunately it is not the case in my upgrade of Intern for Candy Chat, meaning I need to find another minimal reproduction. |
When run against Selenium Standalone in a VirtualBox VM:
|
And now I'm seeing the same things on the master branch, which was not the case before. I'll take this elsewhere until I have something more conclusive. Apologies for the noise guys. |
My trouble seems to be rooted in the fact that Intern 3 is not closing the TCP socket when a request for the test page completes:
|
Does it by chance help if you change that IIFE to a window.onload = function () {
var internPath = ...
...
require(internConfig, [ 'intern/client' ]);
}; |
Where would I change that, @jason0x43? As far as I can guess, it won't make any difference. It's the HTTP connection, not the content of the response, which is the problem. |
You would change that in client.html (that's the content you're showing above). One issue that I've noticed that that the Selenium |
Unfortunately that didn't make any difference, @jason0x43. This works with Selenium + Chrome, but not Selenium + PhantomJS. Both work with Intern 2.2.2. |
Please make sure you are using PhantomJS 2, PhantomJS 1 is not supported. Can you confirm there is an issue with PhantomJS 2 as well? This example seems to work without trouble against PhantomJS 2 using the latest Intern 3.0.x. |
Apologies, @csnover, it seems this was PhantomJS 1.9.0, which is what ships with Ubuntu 14.04. I'll sort out getting that upgraded and confirm this is fixed. |
It does indeed look like PhantomJS 2 fixes this particular issue, but I'm left with another regression which can be see at candy-chat/candy#417. |
Selenium w/ phantomjs can't cope with theintern/intern-examples#25 (comment). This docker image gives us headless Chrome, and switching to Docker gives us a more modern dev environment anyway.
Demonstrates that this new version hangs when executed against PhantomJS/Selenium.
The output I see is:
I do not see any log output in Selenium or ChromeDriver logs. AFAICT, Intern is not even attempting a connection.