Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade base image to Python 3.12 #14

Merged
merged 3 commits into from
Oct 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@
# - https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html#ansible-core-support-matrix
# and also maybe (in case want to install ansible community):
# - https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html#ansible-community-changelogs
# and ansible/python compatibility:
# - https://endoflife.date/ansible#compatibility
#
ARG BASE_IMAGE="python:3.11.7-slim"
ARG PYCMD="/usr/local/bin/python3.11"
ARG BASE_IMAGE="python:3.12.7-slim"
ARG PYCMD="/usr/local/bin/python3.12"
ARG SYS_ZONEINFO="Europe/Berlin"
ARG ANSIBLE_HOME="/usr/share/ansible"
ARG ANSIBLE_GALAXY_CLI_COLLECTION_OPTS="-v"
Expand All @@ -16,7 +18,7 @@
ARG ANSIBLE_USER="thehedhly"

# Base build stage
FROM $BASE_IMAGE as base

Check warning on line 21 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible-core)

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 21 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible-core, 2.16)

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 21 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible-core, 2.17)

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 21 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible)

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 21 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible, 9)

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 21 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible, 10)

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/
ARG BASE_IMAGE
ARG PYCMD
ARG ANSIBLE_INSTALL_REFS
Expand All @@ -27,7 +29,7 @@
&& "$PYCMD" -m pip install --no-cache-dir "$ANSIBLE_INSTALL_REFS"

# Galaxy build stage
FROM base as galaxy

Check warning on line 32 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible-core)

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 32 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible-core, 2.16)

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 32 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible-core, 2.17)

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 32 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible)

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 32 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible, 9)

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 32 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible, 10)

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/
ARG ANSIBLE_HOME
ARG ANSIBLE_GALAXY_CLI_COLLECTION_OPTS
ARG ANSIBLE_GALAXY_CLI_ROLE_OPTS
Expand All @@ -37,10 +39,10 @@
&& ANSIBLE_GALAXY_DISABLE_GPG_VERIFY=1 ansible-galaxy collection install "$ANSIBLE_GALAXY_CLI_COLLECTION_OPTS" -r requirements.yml --collections-path "$ANSIBLE_HOME/collections"

# Final build stage
FROM base as final

Check warning on line 42 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible-core)

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 42 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible-core, 2.16)

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 42 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible-core, 2.17)

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 42 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible)

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 42 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible, 9)

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 42 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible, 10)

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/
ARG ANSIBLE_HOME
ARG ANSIBLE_USER
ENV ANSIBLE_CONFIG "/home/$ANSIBLE_USER/.ansible.cfg"

Check warning on line 45 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible-core)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 45 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible-core, 2.16)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 45 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible-core, 2.17)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 45 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 45 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible, 9)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 45 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ansible, 10)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

COPY --from=galaxy $ANSIBLE_HOME $ANSIBLE_HOME

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ In accordance with both ansible community projects, __ansible community package_
## Build arguments
| Name | description | default |
|------|---------|---------|
| `BASE_IMAGE` | Base docker image. | python:3.11.7-slim |
| `BASE_IMAGE` | Base docker image. | python:3.12.7-slim |
| `PYCMD` | Python binary location.<br>:information_source: See also `BASE_IMAGE` | /usr/local/bin/python3.11 |
| `SYS_ZONEINFO` | System time zone. | Europe/Berlin |
| `ANSIBLE_INSTALL_REFS` | Ansible installation package.<br>You can install a specific version of a ansible community package or ansible-core, e.g.:<br><ul><li>ansible-core==2.16.0</li>or<li>ansible==9</li></ul> | ansible-core |
Expand Down