Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply rubocop in salt_runner_test #96

Merged

Conversation

bastian-src
Copy link
Contributor

Fixes missing space inside brackets.

This was ignored in a previous run: https://github.com/theforeman/smart_proxy_salt/actions/runs/12086309119/job/33705346511

However, I'm not sure why it didn't turn the pipeline red?

Fixes missing space inside brackets
@evgeni
Copy link
Member

evgeni commented Dec 4, 2024

However, I'm not sure why it didn't turn the pipeline red?

Splendid question. I'll go dig

@bastian-src bastian-src merged commit bb0f529 into theforeman:master Dec 4, 2024
11 checks passed
@evgeni
Copy link
Member

evgeni commented Dec 4, 2024

task.fail_on_error = false

@bastian-src
Copy link
Contributor Author

Thanks for the quick review! Shall we change the fail_on_error?

@evgeni
Copy link
Member

evgeni commented Dec 4, 2024

#97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants