Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix report upload #89

Merged
merged 2 commits into from
May 24, 2024
Merged

Conversation

bochi
Copy link
Contributor

@bochi bochi commented May 15, 2024

Servus,

yaml.load() is deprecated is newer version of pyyaml

https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation

so when using salt in later version the report upload will fail.

Changing to safe_load fixes this issue (which is recommended anyway)

@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

@nadjaheitmann
Copy link
Contributor

Thanks @bochi for the fix. Here is a corresponding issue: #88 It mentions two more occurrences of the yaml.load() . Would be good to fix everything.

@bochi
Copy link
Contributor Author

bochi commented May 17, 2024

Done :)
Is upload-salt-reports actually still used?

@nadjaheitmann
Copy link
Contributor

Thanks!

Is upload-salt-reports actually still used?

At least it is still packaged :)

@bastian-src
Copy link
Contributor

LGTM, thanks!

Is upload-salt-reports actually still used?

As it is replaced by the runner, we should remove it and not package it in the future anymore.

@nadjaheitmann nadjaheitmann merged commit a163a3c into theforeman:master May 24, 2024
9 checks passed
@nadjaheitmann
Copy link
Contributor

Thank you @bochi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants