-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uninitialized constant ForemanRhCloud::VERSION #915
Conversation
Thanks, @stejskalleos, that could do it. We could also try to do it future-proof: since we already remove that constant from Zeitwerk loader, we can explicitly require it in the same initializer, so we don't need to require it in each file that potentially uses that constant. require 'foreman_rh_cloud/version'
Rails.autoloaders.main.ignore(
ForemanRhCloud::Engine.root.join('lib/foreman_rh_cloud/version.rb')
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like @ofedoren method so we don't have to include it in each file, @stejskalleos can you update the pr and we can test
I've also been getting some problems in foreman_theme_satellite with |
AFAIU, |
9800ec3
to
5a03d41
Compare
Workflows: - insights client registration - rh_cloud_inventory:report:generate task
5a03d41
to
59e894d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @stejskalleos, seems to fix the issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stejskalleos
Workflows: