Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting: One sentence per line #3423

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

maximiliankolb
Copy link
Contributor

@maximiliankolb maximiliankolb commented Nov 4, 2024

What changes are you introducing?

minor formatting and style chnage

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Follow-up to #3408

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

@asteflova asteflova added tech review done No issues from the technical perspective style review done No issues from docs style/grammar perspective labels Nov 4, 2024
@apinnick
Copy link
Contributor

apinnick commented Nov 6, 2024

I think it is OK to merge and CP this PR because there is a separate PR to fix the broken links.

@apinnick apinnick merged commit 80b71a0 into theforeman:master Nov 6, 2024
8 of 9 checks passed
apinnick pushed a commit that referenced this pull request Nov 6, 2024
* Convert to one sentence per line

* Rephrase make sure to ensure

(cherry picked from commit 80b71a0)
@apinnick
Copy link
Contributor

apinnick commented Nov 6, 2024

Merged to 'master' and cherry-picked:

@maximiliankolb maximiliankolb deleted the one_sentence_per_line branch November 6, 2024 13:43
@apinnick
Copy link
Contributor

apinnick commented Nov 7, 2024

Forgot to CP to 3.13. Will do.

apinnick pushed a commit that referenced this pull request Nov 7, 2024
* Convert to one sentence per line

* Rephrase make sure to ensure

(cherry picked from commit 80b71a0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants