Merge pull request #226 from fezfez/fixphp8

fix #225
thecodingmachine · Jul 10, 2020 · 9f27717 · 9f27717
2 parents 85e21ee + 6377548
commit 9f27717
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/generated/sockets.php b/generated/sockets.php
@@ -794,7 +794,7 @@ function socket_write($socket, string $buffer, int $length = 0): int
  * @throws SocketsException
  *
  */
-function socket_wsaprotocol_info_export(resource  $socket, int $target_pid): string
+function socket_wsaprotocol_info_export($socket, int $target_pid): string
 {
     error_clear_last();
     $result = \socket_wsaprotocol_info_export($socket, $target_pid);

diff --git a/generator/src/PhpStanFunctions/PhpStanType.php b/generator/src/PhpStanFunctions/PhpStanType.php
@@ -106,6 +106,8 @@ public function getSignatureType(?int $errorType = null): string
                 $type = 'array'; //typed array has to be untyped
             } elseif (\strpos($type, '[]') !== false) {
                 $type = 'iterable'; //generics cannot be typehinted and have to be turned into iterable
+            } elseif (\strpos($type, 'resource') !== false) {
+                $type = ''; // resource cant be typehinted
             }
         }