MAT-363 – attempted extra Donation locking #893
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… persistence safety
bdsl
force-pushed
the
MAT-363-extra-locks-wip
branch
2 times, most recently
from
de15aff to
97ecb0c
Compare
… with ID lookups followed by find with lock Also hopefully makes the DonationRepo usage a bit more self-documenting etc
bdsl
force-pushed
the
MAT-363-extra-locks-wip
branch
from
97ecb0c to
0401070
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #893 +/- ##
=============================================
- Coverage 76.43% 76.35% -0.09%
- Complexity 966 972 +6
=============================================
Files 89 89
Lines 4180 4220 +40
=============================================
+ Hits 3195 3222 +27
- Misses 985 998 +13 ☔ View full report in Codecov by Sentry. |
|
@NoelLH is this still relevant? |
Maybe. I need to review the risk of not locking in the extra places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Like #892 plus locks that seemed prudent, but in one case also break integration tests.