-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DON-998: rename mandate donation amount #1128
base: develop
Are you sure you want to change the base?
Conversation
src/Domain/RegularGivingMandate.php
Outdated
@@ -34,7 +34,7 @@ class RegularGivingMandate extends SalesforceWriteProxy | |||
public PersonId $donorId; | |||
|
|||
#[ORM\Embedded(columnPrefix: '')] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm I'm getting more tests failing than you have, but maybe this will fix it?
#[ORM\Embedded(columnPrefix: '')] | |
/** @todo - consider renaming db columns to match property names, will be easier to do before we have | |
* any data in prod that we need to keep. | |
* | |
* This is donationAmount rather than simply Amount because we plan to add a `matchedAmount` property | |
* next to it. | |
*/ | |
#[ORM\Embedded(columnPrefix: 'amount')] |
Then we're doing the rename everywhere except in the actual database .
02c152e
to
d3e2a8c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unfreeze-trunk #1128 +/- ##
===============================================
Coverage 73.85% 73.85%
===============================================
Files 123 123
Lines 5371 5371
===============================================
Hits 3967 3967
Misses 1404 1404 ☔ View full report in Codecov by Sentry. |
@dorota-joanna do you want to merge this? |
No description provided.