Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DON-998: rename mandate donation amount #1128

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

dorota-joanna
Copy link
Contributor

No description provided.

@@ -34,7 +34,7 @@ class RegularGivingMandate extends SalesforceWriteProxy
public PersonId $donorId;

#[ORM\Embedded(columnPrefix: '')]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I'm getting more tests failing than you have, but maybe this will fix it?

Suggested change
#[ORM\Embedded(columnPrefix: '')]
/** @todo - consider renaming db columns to match property names, will be easier to do before we have
* any data in prod that we need to keep.
*
* This is donationAmount rather than simply Amount because we plan to add a `matchedAmount` property
* next to it.
*/
#[ORM\Embedded(columnPrefix: 'amount')]

Then we're doing the rename everywhere except in the actual database .

@dorota-joanna dorota-joanna force-pushed the DON-998-rename-donation-amounts branch from 02c152e to d3e2a8c Compare December 10, 2024 13:09
bdsl
bdsl previously approved these changes Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.85%. Comparing base (4ad77d7) to head (d3e2a8c).

Files with missing lines Patch % Lines
src/Domain/RegularGivingMandate.php 66.66% 2 Missing ⚠️
src/Application/Commands/SetupTestMandate.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           unfreeze-trunk    #1128   +/-   ##
===============================================
  Coverage           73.85%   73.85%           
===============================================
  Files                 123      123           
  Lines                5371     5371           
===============================================
  Hits                 3967     3967           
  Misses               1404     1404           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdsl
Copy link
Contributor

bdsl commented Dec 10, 2024

@dorota-joanna do you want to merge this?

Base automatically changed from unfreeze-trunk to develop December 10, 2024 17:57
@bdsl bdsl dismissed their stale review December 10, 2024 17:57

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants