Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DON-998: view mandate link #1806

Merged
merged 2 commits into from
Dec 19, 2024
Merged

DON-998: view mandate link #1806

merged 2 commits into from
Dec 19, 2024

Conversation

dorota-joanna
Copy link
Contributor

2024-12-18_17-04
2024-12-18_17-05

bdsl
bdsl previously approved these changes Dec 18, 2024
Copy link
Contributor

@bdsl bdsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Button LGTM. I don't know really if we want a button here or a regular link but IMHO that can be dealt with in QA.

Do you want to also replace the alert with a redirect to the new mandate page?

alert(prefix + JSON.stringify(mandate));

@dorota-joanna
Copy link
Contributor Author

dorota-joanna commented Dec 19, 2024

alert(prefix + JSON.stringify(mandate

Button LGTM. I don't know really if we want a button here or a regular link but IMHO that can be dealt with in QA.

Do you want to also replace the alert with a redirect to the new mandate page?

alert(prefix + JSON.stringify(mandate));

@bdsl do we need the redirect, when the button is assigned url ? (updated in my last commit, tested it still works, lmk if this is what you had in mind!

@bdsl
Copy link
Contributor

bdsl commented Dec 19, 2024

alert(prefix + JSON.stringify(mandate

Button LGTM. I don't know really if we want a button here or a regular link but IMHO that can be dealt with in QA.
Do you want to also replace the alert with a redirect to the new mandate page?

alert(prefix + JSON.stringify(mandate));

@bdsl do we need the redirect, when the button is assigned url ? (updated in my last commit, tested it still works, lmk if this is what you had in mind!

Yep, 501d865 is what I had in mind. Thanks!

@dorota-joanna dorota-joanna merged commit 993f40a into develop Dec 19, 2024
4 checks passed
@dorota-joanna dorota-joanna deleted the DON-998-view-mandate-link branch December 19, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants