Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don 1065 logout in menu #1804

Merged
merged 7 commits into from
Dec 18, 2024
Merged

Don 1065 logout in menu #1804

merged 7 commits into from
Dec 18, 2024

Conversation

bdsl
Copy link
Contributor

@bdsl bdsl commented Dec 17, 2024

image

NoelLH
NoelLH previously approved these changes Dec 17, 2024
Copy link
Contributor

@NoelLH NoelLH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems like the tests are passing now too

@@ -335,20 +335,6 @@ export class TransferFundsComponent implements AfterContentInit, OnInit {
return Math.floor(creditAmount * (tipPercentage / 100));
}

logout() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bdsl bdsl marked this pull request as ready for review December 18, 2024 12:19
@bdsl bdsl merged commit 7d7c2cd into develop Dec 18, 2024
4 checks passed
@bdsl bdsl deleted the DON-1065-logout-in-menu branch December 18, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants