DON-1066: Link to regular giving agreement from card payment #1800
Conversation
bdsl
force-pushed
the
DON-1066-show-mandate-on-donation
branch
3 times, most recently
from
595770c to
a6a0959
Compare
bdsl
force-pushed
the
DON-1066-show-mandate-on-donation
branch
from
a6a0959 to
aae2377
Compare
| if ( !this.campaign.isRegularGiving ) { | ||
| throw new Error("Campaign " + this.campaign.id + " is not a regular giving campaign"); | ||
| } | ||
|
|
There was a problem hiding this comment.
duplicated the previous throw.
| @@ -24,7 +27,7 @@ div.donation { | |||
| height: 100%; | |||
| justify-content: space-between; | |||
| flex-direction: column; | |||
| a:link, a:visited, a:hover { | |||
| a.charityName:link, a.charityName:visited, a.charityName:hover { | |||
There was a problem hiding this comment.
I'm not sure about the mix of link styles here, and the card not all being linked like the home highlight cards. Is there a way donors would figure out that a bold charity name is a mandate link based on other styling around the app?
There was a problem hiding this comment.
The charity name isn't a link to the mandate, it's a link to the campaign. The link to the mandate is blue and not bold.
I'm also not sure about mixing the styles though. The campaign link style is unchanged. I can't remember for sure why we didn't make that one blue but I guess we thought it was not very important and having it blue might make the page too busy.
The mandate links are probably more vital for people to be able to find easily.
There was a problem hiding this comment.
Right, sorry for typo. I think I did see what it linked to but still feel it's better to either re-style the campaign link somehow or not link at all.
I agree the mandate one is the priority and is good as-is. I don't think that precludes the rest of the card effectively becoming a big campaign link if we can make that work, since that mostly mirrors a design pattern we have already used on the home page.
There was a problem hiding this comment.
@NoelLH do you have a view on a way forward for this? I looked on the comment on DON-983 to see if we discussed the links being black rather than blue. There are a lot of comments there so I may have missed it, but I can't see that we did.
I think having the entire card linked probably doesn't make sense unless it was a link to the donation, which we aren't currently doing. For now we link the campaign and the mandate. I think we may well want to add a link to the donation as a its own page (which may look exactly the same as our current donation thank you page) in future.
There was a problem hiding this comment.
(wrote my 11:18 message before I saw your 11:11 message)
There was a problem hiding this comment.
Thanks @bdsl from a design perspective, there is a lot of white space on the right hand side that it would be good to use / remove if possible, maybe through more padding on the left
There was a problem hiding this comment.
@DomTBG The width is going to be quite dependant on the number of donations you have and the width of your screen, and if we adjust it we'll need to test with a range of screen sizes again so I don't know if we need to get into that now - it doesn't seem like an issue that comes from adding the link to the regular giving mandate.
Do you have a view about the link styling for the link to the mandate and the link to the charity?
There was a problem hiding this comment.
OK @bdsl let's leave the white space question for now.
I don't know that we need to link to the campaign for any donations - it's not like we link to the campaign in the donation receipt.
There was a problem hiding this comment.
@DomTBG No, but the donation receipt (template here ) does link to the charity's own website, as well as giving there postal address, phone number etc.
I reviewed the Jira comments on DON-983 when we introduced this page, sadly there doesn't seem to be any record of discussion about the links to campaign pages. I think I just included them in my initial version of this page and no-one objected.
But I've pushed commit d28cc01 here to remove the link to the campaign so for now if you have a regular giving donation and an ad-hoc donation they will look like this:
I do think at some point we're likely to want to add in a link to a full page of details about each donation, we may have to revisit this design then.
There was a problem hiding this comment.
we are considering removing all of that info on the donation receipt though @bdsl
See discussion at #1800 (comment)
Screenshot to show how this would look with one regular donation and one ad-hoc donation side by side: