DON-1092 – fix campaign card grid input focus breaking Safari scroll positions #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoelLH
commented
Nov 27, 2024
| @@ -124,6 +130,16 @@ export class ExploreComponent implements OnDestroy, OnInit { | |||
| } | |||
|
|
|||
| onScroll() { | |||
| if (this.scroller.getScrollPosition()[1] < this.smallestSignificantScrollPx) { | |||
| this.blurredSinceLastMajorScroll = false; | |||
| return; | |||
There was a problem hiding this comment.
This early return may stop some more() calls, but since we do the equivalent on meta-campaign already I can't see that causing major problems.
bdsl
reviewed
Nov 27, 2024
bdsl
reviewed
Nov 27, 2024
Co-authored-by: Barney Laurance <[email protected]>
Co-authored-by: Barney Laurance <[email protected]>
bdsl
reviewed
Nov 27, 2024
| @@ -124,6 +130,16 @@ export class ExploreComponent implements OnDestroy, OnInit { | |||
| } | |||
|
|
|||
| onScroll() { | |||
| if (this.scroller.getScrollPosition()[1] < this.smallestSignificantScrollPx) { | |||
| this.blurredSinceLastMajorScroll = false; | |||
There was a problem hiding this comment.
I don't think I'm following the logic here. This has a small scroll position so I guess is a minor scroll? So why does it affect the state of blurredSinceLastMajorScroll?
There was a problem hiding this comment.
@bdsl The idea is that if you go back to the top, you are more likely to be about to interact with the search fields. So there's a reasonable chance that it will be useful to blur afresh when you're done. I'll add a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.