DON-1092 – refine post-search scroll behaviour #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NoelLH
commented
Nov 26, 2024
NoelLH
commented
- give post-search scroll position change enough time to go to the right place
- fix no-op navigation with scroll position impact
bdsl
reviewed
Nov 26, 2024
Comment on lines
189
to
190
| // Angular scrolls automatically, using setTimeout to delay this scroll to a later task so this gets to | ||
| // set the position the page is left in. |
There was a problem hiding this comment.
probably worth changing this comment, "later task" made sense when delay was set at zero, now we're delaying it more than that. Not sure exactly what it is that we're waiting the 200ms for. Maybe something like this?
Suggested change
| // Angular scrolls automatically, using setTimeout to delay this scroll to a later task so this gets to | |
| // set the position the page is left in. | |
| // Angular scrolls automatically, using setTimeout to delay this scroll to happen after the automatic scroll |
There was a problem hiding this comment.
I'm also not sure exactly, but think it's connected to the router action and possibly to its scrollPositionRestoration feature which we have set to true.
Updated the comments to match my understanding better at 1bec863
bdsl
previously approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.