DON-752: Create login page #1401
Conversation
Purely the result of running `ng generate component --standalone login`
…modal There may be scope to tidy up by removing some duplication, or it might be that the code needs to be tweaked a bit for the different context and so two separate copies makes more sense.
bdsl
changed the title
(I'd like the message not to be red though)
(makes sense in the modal, doesn't make sense in the full page version)
Cancel was copied from modal, doesn't make sense in page context
…ntend on login This can be used to make the login page work as a gate in front of any other page that will require login to see
| if (! isLoggedIn) { | ||
| return true; | ||
| } else { | ||
| return router.parseUrl('/'); |
There was a problem hiding this comment.
todo - inject the Activated route and redirect the same way that the login component does on successful login, i.e. not always to the home page.
| siteKey="{{ recaptchaIdSiteKey }}" | ||
| ></re-captcha> | ||
|
|
||
| <div *ngIf="forgotPassword else logIn"> |
There was a problem hiding this comment.
may or may not want to move forgotPassword out to a separate page.
| ]], | ||
| password: [null, [ | ||
| Validators.required, | ||
| Validators.minLength(10), |
There was a problem hiding this comment.
not sure it's worth having a minLength validation on the password field here. It's here because I copied this from the login modal. Min length is good when setting a new password, but I think it might be more confusing than helpful when trying to authenticate with an existing password.
The only password validation rule as far as the user is concerned here is that the password has to match what's set on the account. Yes we know that that implies it will be at least 10 characters, but that feels a bit arbitrary to enforce here.
There was a problem hiding this comment.
I think you're right, I don't remember being notified about password length on any login page, but maybe it's good to check length at the form level before checking against db, as we know it can't be right and won't make unnecessary db calls?
There was a problem hiding this comment.
I think if we do that for performance reasons then we don't need to tell the user about it, as it just makes things more complicated for them - and if we do it it makes more sense to do it in the Identity server instead of in frontend. I'll leave it here for now but likely change in a later PR.
Login page is at
/loginIncludes function to redirect the user to any other page on the site if
?r=<redirectTarget>is added to the URL. My plan is to use a router guard to redirect attempts to access pages likemy-accountto/login?r=my-account