DON-904 - tweak new My Account timeout #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only allow setting it client-side, and clear it when appropriate. Also fix a typo in a similar bit of metacampaign cleanup
bdsl
reviewed
Nov 3, 2023
| @@ -119,7 +119,7 @@ export class MetaCampaignComponent implements AfterViewChecked, OnDestroy, OnIni | |||
|
|
|||
| ngOnDestroy() { | |||
| if (isPlatformBrowser(this.platformId) && this.tickerUpdateTimer) { | |||
| clearInterval(this.tickerUpdateTimer); | |||
| clearTimeout(this.tickerUpdateTimer); | |||
There was a problem hiding this comment.
Looks good, I see this was set by setTimeout not setInterval so I guess clearInterval was a mistake before.
bdsl
reviewed
Nov 3, 2023
| public person: Person; | ||
|
|
||
| public paymentMethods: PaymentMethod[]|undefined = undefined; | ||
| registerErrorDescription: string | undefined; | ||
| registerSucessMessage: string | undefined; | ||
| protected readonly faExclamationTriangle = faExclamationTriangle; | ||
|
|
||
| private savedCardsTimer: ReturnType<typeof setTimeout>; // https://stackoverflow.com/a/56239226 |
There was a problem hiding this comment.
Annoying that the type is different in Node and browsers, but this looks like a good solution. And comment is definitely needed - thanks.
bdsl
reviewed
Nov 3, 2023
bdsl
reviewed
Nov 3, 2023
bdsl
previously approved these changes
Nov 3, 2023
Co-authored-by: Barney Laurance <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only allow setting it client-side, and clear
it when appropriate.
Also fix a typo in a similar bit of metacampaign
cleanup