DON-819: Use snackbar to show errors in stepper recieve updates step #1327
Conversation
bdsl
force-pushed
the
DON-819-receive-updates-errors
branch
from
0a8823c to
7be0d10
Compare
| <p class="error" *ngIf="triedToLeaveMarketing && marketingGroup.get('optInCharityEmail')?.hasError('required')" aria-live="assertive"> | ||
| Please choose whether you wish to receive updates from {{ campaign.charity.name }}. | ||
| <p class="error" *ngIf="triedToLeaveMarketing && errorMessagesForMarketingStep().optInCharityEmailRequired" aria-live="assertive"> | ||
| {{errorMessagesForMarketingStep().optInCharityEmailRequired}}. |
There was a problem hiding this comment.
Maybe we should remove this or adjust it if don819FlagEnabled - given that this step is quite short duplicating the message here and in the snackbar feels excessive. Not sure.
There was a problem hiding this comment.
True, it does feel a bit excessive, especially that the entire section is in view
There was a problem hiding this comment.
Right. I think I'll leave it for now though, the popup is temporary and is there to make sure the donor's attention is drawn, the message above stays on screen until the user does something or their computer breaks so they can read it at their leisure. And it's consistent with the other sections.
Maybe we'll decide to take it off later when we get more people involved to review the page as a whole with these messages.
Message now pops up every time the donor tries to continue from this step without filling in their choices: