DON-888 – A/B testing setup + proof of concept #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove placeholder element * make headline copy A/B test variable * make expansion panel detail copy A/B test variable
bdsl
reviewed
Oct 4, 2023
Comment on lines
+292
to
+302
| activate: (_event: any) => { | ||
| // No change from the original form. | ||
| console.log('Original test variant active!'); | ||
| } | ||
| }, | ||
| { | ||
| name: environment.matomoAbTest.variantName, | ||
| activate: (_event: any) => { | ||
| this.alternateCopy = true; | ||
| console.log('Copy B test variant active!'); | ||
| } |
There was a problem hiding this comment.
Suggested change
| activate: (_event: any) => { | |
| // No change from the original form. | |
| console.log('Original test variant active!'); | |
| } | |
| }, | |
| { | |
| name: environment.matomoAbTest.variantName, | |
| activate: (_event: any) => { | |
| this.alternateCopy = true; | |
| console.log('Copy B test variant active!'); | |
| } | |
| activate: (_event: unknown) => { | |
| // No change from the original form. | |
| } | |
| }, | |
| { | |
| name: environment.matomoAbTest.variantName, | |
| activate: (_event: unknown) => { | |
| this.alternateCopy = true; | |
| } |
There was a problem hiding this comment.
As I mentioned on Jira, I think I'd rather keep browser logs on activation, at least for now, to make sure we can diagnose any behaviour we're not expecting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.