Skip to content

Commit

Permalink
Merge pull request #1787 from thebiggive/develop
Browse files Browse the repository at this point in the history
Develop -> main
  • Loading branch information
NoelLH authored Nov 29, 2024
2 parents fcbff51 + 201e802 commit 8e59b7e
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 12 deletions.
16 changes: 8 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@
"@angular/platform-server": "^18.2.8",
"@angular/router": "^18.2.8",
"@angular/ssr": "^18.2.8",
"@biggive/components": "^202411271427.0.0",
"@biggive/components-angular": "^202411271427.0.0",
"@biggive/components": "^202411281608.0.0",
"@biggive/components-angular": "^202411281608.0.0",
"@fortawesome/angular-fontawesome": "~0.15.0",
"@fortawesome/free-brands-svg-icons": "^6.6.0",
"@fortawesome/free-solid-svg-icons": "^6.6.0",
Expand Down
2 changes: 1 addition & 1 deletion src/app/donation-thanks/donation-thanks.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ <h2>Thank you!</h2>
<biggive-social-icon
service="Twitter"
label-prefix="Share"
url="https://twitter.com/share?url={{ encodedShareUrl }}&text={{ encodedPrefilledText }}"
url="https://x.com/intent/post?url={{ encodedShareUrl }}&text={{ encodedPrefilledText }}"
background-colour="tertiary"
icon-colour="black"
wide="true"
Expand Down
4 changes: 4 additions & 0 deletions src/app/highlight-cards/HighlightCard.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,10 @@ describe('highlightCard', () => {
});

it('should replace CC24 link with metacampaign page', () => {
if (new Date() > new Date('2025-02-01')) {
pending('Implementation was only made for 2024');
}

const cardFromApi = cardLinkingTo("https://example-blog.com/christmas-challenge/");

const highlightCardForHomepage = SFAPIHighlightCardToHighlightCard(
Expand Down
2 changes: 1 addition & 1 deletion src/app/highlight-cards/HighlightCard.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export const SFAPIHighlightCardToHighlightCard = (experienceUriPrefix: string, b
let href = replaceURLOrigin(experienceUriPrefix, blogUriPrefix, donateUriPrefix, sfApiHighlightCard.button.href);

// temp fix for 2024. Will need to think of something better and probably move this logic to SF for next year.
if (href.pathname.includes('christmas-challenge')) {
if (href.pathname.includes('christmas-challenge') && (new Date() < new Date('2025-02-01'))) {
href = new URL(donateUriPrefix + '/christmas-challenge-2024');
}

Expand Down

0 comments on commit 8e59b7e

Please sign in to comment.