Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ctypes] TVB-2719 Add ability to specify if faces' vertices are 1-indexed #44

Open
wants to merge 9 commits into
base: trunk
Choose a base branch
from

Conversation

ayan-b
Copy link
Member

@ayan-b ayan-b commented Jun 24, 2020

Closes #41

This is on top of #40

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

❗ No coverage uploaded for pull request base (trunk@af53f95). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             trunk      #44   +/-   ##
========================================
  Coverage         ?   86.79%           
========================================
  Files            ?        1           
  Lines            ?       53           
  Branches         ?        0           
========================================
  Hits             ?       46           
  Misses           ?        7           
  Partials         ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af53f95...b2e18ab. Read the comment docs.

@ayan-b ayan-b changed the title TVB-2719 Add ability to specify in faces' vertex in 1-indexed TVB-2719 Add ability to specify if faces' vertex is 1-indexed Jun 24, 2020
@ayan-b ayan-b changed the title TVB-2719 Add ability to specify if faces' vertex is 1-indexed TVB-2719 Add ability to specify if faces' vertices is 1-indexed Jun 24, 2020
@ayan-b ayan-b changed the title TVB-2719 Add ability to specify if faces' vertices is 1-indexed TVB-2719 Add ability to specify if faces' vertices are 1-indexed Jun 28, 2020
@liadomide liadomide added this to the GSOC2020 milestone Jun 29, 2020
@liadomide
Copy link
Member

liadomide commented Jun 29, 2020

This will need to be merged after PR #40 as it relies on those changes in the implementation.

@ayan-b ayan-b changed the title TVB-2719 Add ability to specify if faces' vertices are 1-indexed [Ctypes] TVB-2719 Add ability to specify if faces' vertices are 1-indexed Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing on cortex 2x120k
2 participants