plan: distribute more binary joins #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
force-pushed
the
mhoffmann-distribute-more-joins
branch
7 times, most recently
from
41875c1 to
f672dde
Compare
|
I think that we can solve the problem in the engine client by passing partition labels as remote engine labels. This way we don't need to change the engine, we can just add a flag in Thanos to determine which labels should be used to identify a remote engine. |
MichaHoffmann
force-pushed
the
mhoffmann-distribute-more-joins
branch
from
f672dde to
ee3311b
Compare
Removed the partition labels part and just distribute if the matching contains all engine labels for now! |
MichaHoffmann
force-pushed
the
mhoffmann-distribute-more-joins
branch
3 times, most recently
from
fd90edb to
de122dc
Compare
* distribute joins that can be executed within a remote engine Signed-off-by: Michael Hoffmann <[email protected]>
MichaHoffmann
force-pushed
the
mhoffmann-distribute-more-joins
branch
from
de122dc to
d315a56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can distribute if we are either matching
on (...)and "..." contains at least one engine label or if we are matchingignoring (...)and "..." does not contain an engine label. If we are matching without either, i.e.X * Ywe are implicitly matchingignoring ().