plan: fix distributed avg #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
force-pushed
the
mhoffm-fix-distributed-avg
branch
from
e83723a to
28cf306
Compare
MichaHoffmann
commented
Dec 5, 2023
| LHS: &sum, | ||
| RHS: &count, | ||
| VectorMatching: &parser.VectorMatching{ | ||
| Include: aggr.Grouping, |
There was a problem hiding this comment.
We need to include that to make sure that name is not dropped ( its usually dropped by vector binary "/" )
The we should rewrite to sum by (xxx) / on (xxx) count by (xxx). Signed-off-by: Michael Hoffmann <[email protected]>
MichaHoffmann
force-pushed
the
mhoffm-fix-distributed-avg
branch
from
28cf306 to
a4f695c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The we should rewrite to sum by (xxx) / on (xxx) count by (xxx).