Skip to content

Commit

Permalink
engine: add Close method for nopQueryTracker
Browse files Browse the repository at this point in the history
Unblock Thanos Prometheus go.mod update by providing missing method:

```
../../go/pkg/mod/github.com/thanos-io/[email protected]/engine/engine.go:173:41: cannot use nopQueryTracker{} (value of type nopQueryTracker) as promql.QueryTracker value in variable declaration: nopQueryTracker does not implement promql.QueryTracker (missing method Close)
```

Signed-off-by: Giedrius Statkevičius <[email protected]>
  • Loading branch information
GiedriusS committed Sep 20, 2024
1 parent de6d9f8 commit 746dcf6
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions engine/engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -687,6 +687,7 @@ type nopQueryTracker struct{}
func (n nopQueryTracker) GetMaxConcurrent() int { return -1 }
func (n nopQueryTracker) Insert(ctx context.Context, query string) (int, error) { return 0, nil }
func (n nopQueryTracker) Delete(insertIndex int) {}
func (n nopQueryTracker) Close() error { return nil }

func recoverEngine(logger log.Logger, plan logicalplan.Plan, errp *error) {
e := recover()
Expand Down

0 comments on commit 746dcf6

Please sign in to comment.