Added Hints to Icons on Hover #1088
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tupaschoal
reviewed
Dec 7, 2024
Comment on lines
+216
to
+223
| '<span title="Delete Entry">-</span>' + | ||
| '</div>' + | ||
| '<i class="arrow left"></i>' + | ||
| '<i title="Previous Entry" class="arrow left"></i>' + | ||
| '<div class="time-cells" id="' + dateKey + '">' + | ||
| '</div>' + | ||
| '<i class="arrow right"></i>' + | ||
| '<i title="Next Entry" class="arrow right"></i>' + | ||
| '<div class="sign-cell plus-sign">' + | ||
| '<span>+</span>' + | ||
| '<span title="Add Entry">+</span>' + |
There was a problem hiding this comment.
These should not be hardcoded. If there are no equivalent strings on the translation files, they need to be added.
yarrumevets
reviewed
Dec 17, 2024
| @@ -213,14 +213,14 @@ class FlexibleMonthCalendar extends BaseCalendar | |||
| '<img src="../assets/waiver.svg" height="16" class="waiver-img">' + | |||
| '</div>' + | |||
| '<div class="sign-cell minus-sign">' + | |||
| '<span>-</span>' + | |||
| '<span title="Delete Entry">-</span>' + | |||
There was a problem hiding this comment.
I think this might be what you need for "Delete Entry"
<span
title="${this._getTranslation(
'$FlexibleMonthCalendar.remove-entry')}"
>-</span>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#1086 (comment)
Context / Background
Some of the icons in the application did not have a hint when hovered over them while others did. It was unclear what the icons without the hints did until using them more and looking into the overall purpose of the application.
What change is being introduced by this PR?
I saw that some of the other icons (such as the "Go to Current Month" icon) already had a hint when I would hover over it. I found where this was happening in the code and replicated that code to do the same thing for icons that did not have this functionality.
I added a "title" attribute to the HTML code for the icons which provides text when hovered over. This will inform users about what these icons do.
How will this be tested?