feat: Use BaseReactPackage instead of TurboReactPackage
#558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for RN 0.77 apparently. TurboReactPackage is deprecated on new arch. No idea why. I am not sure about backwards compatibility either, sorry. Feel free to close this PR if this isn't backwards compatible.
|
TurboReactPackage will be restored and available for RN 0.77: reactwg/react-native-releases#652 |
|
Interesting. |
|
Looks like it was introduced in 0.74 (facebook/react-native@7a31ecd). It is restored, but still marked as deprecated so I assume it will just be removed later. TBH I am not sure what other popular libraries use as a backwards compatibility target (@mrousavy what about you). |
|
For Nitro it's easy - I just use I think all my packages are gonna be |
|
I think I will do a major with 0.74+ compat |
janicduplessis
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for RN 0.77 apparently. TurboReactPackage is deprecated on new arch. No idea why.
I am not sure about backwards compatibility either, sorry.
Feel free to close this PR if this isn't backwards compatible.
Summary
Test Plan