fix(ci/artifacthub-images): the artifacthub-ignore comments get lost, #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwrau
force-pushed
the
fix/ci-artifacthub-ignored-images
branch
from
e777c23 to
193dfd4
Compare
cwrau
force-pushed
the
fix/ci-artifacthub-ignored-images
branch
from
193dfd4 to
f9297d2
Compare
cwrau
changed the title
marvinWolff
previously approved these changes
Mar 28, 2024
cwrau
force-pushed
the
fix/ci-artifacthub-ignored-images
branch
from
b34e1ac to
3094734
Compare
🤖 I have diffed this beep boop"/$namespace/$kind/$name.yaml" for normal resources
|
cwrau
force-pushed
the
fix/ci-artifacthub-ignored-images
branch
from
3094734 to
c1b6132
Compare
therefore the developer should just override the image via the artifacthub-values.yaml to `artifacthub-ignore`
which conveniently throws out the `charts/t8s-cluster/templates/management-cluster/clusterClass/openStackClusterTemplate/_openStackClusterTemplateSpec.yaml` ignored image
this aids in debugging
cwrau
force-pushed
the
fix/ci-artifacthub-ignored-images
branch
from
c1b6132 to
36af82c
Compare
marvinWolff
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
therefore the developer should just override the image via the artifacthub-values.yaml to
artifacthub-ignoreThis also forces the detected images to end the line, which conveniently throws out the
charts/t8s-cluster/templates/management-cluster/clusterClass/openStackClusterTemplate/_openStackClusterTemplateSpec.yamlignored image