fix(base-cluster/backup)!: only enable velero if a backupstoragelocation is set #763

tasches · 2024-02-05T07:13:37Z

closes #752

marvinWolff · 2024-02-05T07:51:44Z

This looks fine to me.

But i'm asking myself how the rollout will go.

Most clusters currently aren't using velero, but some do. In those clusters the backupStorageLocation ist not set via the chart. At least not that i'm aware of.
Here we should either move the declaration into the chart or add some sort of configuration option ala existingStorageLocation: <name>.

But im not sure how practical that would be. What do you think @cwrau @tasches ?

charts/base-cluster/templates/backup/credentials.yaml

charts/base-cluster/templates/backup/validation.yaml

charts/base-cluster/values.yaml

cwrau · 2024-02-05T10:35:01Z

You're missing some locations where .backup.enabled is used;

charts/base-cluster/values.yaml
charts/base-cluster/templates/backup/velero.yaml
charts/base-cluster/templates/backup/validation.yaml
charts/base-cluster/templates/backup/migrations/velero-4-to-5.yaml
charts/base-cluster/templates/monitoring/kube-prometheus-stack/_grafana-config.yaml

You can just search for .backup.enabled

cwrau · 2024-02-07T09:00:37Z

You should require defaultLocation if backupStorageLocations is defined;

diff --git a/charts/base-cluster/values.schema.json b/charts/base-cluster/values.schema.json
index d8f2f69..948cc3b 100644
--- a/charts/base-cluster/values.schema.json
+++ b/charts/base-cluster/values.schema.json
@@ -1290,6 +1290,25 @@
           "additionalProperties": false
         }
       },
+      "oneOf": [
+        {
+          "properties": {
+            "backupStorageLocations": {
+              "minProperties": 1
+            }
+          },
+          "required": [
+            "defaultLocation"
+          ]
+        },
+        {
+          "properties": {
+            "backupStorageLocations": {
+              "maxProperties": 0
+            }
+          }
+        }
+      ],
       "additionalProperties": false
     },
     "common": {

In this case I'd also be fine with the if/then;

diff --git a/charts/base-cluster/values.schema.json b/charts/base-cluster/values.schema.json
index d8f2f69..4ac7ee7 100644
--- a/charts/base-cluster/values.schema.json
+++ b/charts/base-cluster/values.schema.json
@@ -1290,6 +1290,18 @@
           "additionalProperties": false
         }
       },
+      "if": {
+        "properties": {
+          "backupStorageLocations": {
+            "minProperties": 1
+          }
+        }
+      },
+      "then": {
+        "required": [
+          "defaultLocation"
+        ]
+      },
       "additionalProperties": false
     },
     "common": {

…ion is set

creation

teutonet-bot · 2024-02-07T15:32:38Z

🤖 I have diffed this beep boop

"/$namespace/$kind/$name.yaml" for normal resources
"/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive
'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease

charts/base-cluster/ci/monitoring-ingress-unauthenticated-values.yaml has no changes

[charts/base-cluster/ci/rbac-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } </script>

    <script>
        
        
    </script>
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id="container">
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters. Your submission is 1,970,178
    <hr>
    <p>
        Something unexpected? Please create a <a href="https://dpaste.freshdesk.com/support/tickets/new">support ticket</a>.
    </p>
</div>
<p>
    <a class="button" href="{$ url 'create' %}" onclick="history.back();return false;">Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>

)

[charts/base-cluster/ci/pagerduty-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } </script>

    <script>
        
        
    </script>
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id="container">
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters. Your submission is 1,975,077
    <hr>
    <p>
        Something unexpected? Please create a <a href="https://dpaste.freshdesk.com/support/tickets/new">support ticket</a>.
    </p>
</div>
<p>
    <a class="button" href="{$ url 'create' %}" onclick="history.back();return false;">Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>

)

[charts/base-cluster/ci/imagepullsecrets-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } </script>

    <script>
        
        
    </script>
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id="container">
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters. Your submission is 1,981,070
    <hr>
    <p>
        Something unexpected? Please create a <a href="https://dpaste.freshdesk.com/support/tickets/new">support ticket</a>.
    </p>
</div>
<p>
    <a class="button" href="{$ url 'create' %}" onclick="history.back();return false;">Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>

)

charts/base-cluster/values.yaml has no changes

[charts/base-cluster/ci/artifacthub-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } </script>

    <script>
        
        
    </script>
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id="container">
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters. Your submission is 4,303,729
    <hr>
    <p>
        Something unexpected? Please create a <a href="https://dpaste.freshdesk.com/support/tickets/new">support ticket</a>.
    </p>
</div>
<p>
    <a class="button" href="{$ url 'create' %}" onclick="history.back();return false;">Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>

)

[charts/base-cluster/ci/disabled-ingress-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } </script>

    <script>
        
        
    </script>
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id="container">
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters. Your submission is 1,944,796
    <hr>
    <p>
        Something unexpected? Please create a <a href="https://dpaste.freshdesk.com/support/tickets/new">support ticket</a>.
    </p>
</div>
<p>
    <a class="button" href="{$ url 'create' %}" onclick="history.back();return false;">Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>

)

[charts/base-cluster/ci/flux-gitrepositories-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } </script>

    <script>
        
        
    </script>
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id="container">
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters. Your submission is 2,436,879
    <hr>
    <p>
        Something unexpected? Please create a <a href="https://dpaste.freshdesk.com/support/tickets/new">support ticket</a>.
    </p>
</div>
<p>
    <a class="button" href="{$ url 'create' %}" onclick="history.back();return false;">Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>

)

[charts/base-cluster/ci/priorityclasses-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } </script>

    <script>
        
        
    </script>
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id="container">
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters. Your submission is 1,970,491
    <hr>
    <p>
        Something unexpected? Please create a <a href="https://dpaste.freshdesk.com/support/tickets/new">support ticket</a>.
    </p>
</div>
<p>
    <a class="button" href="{$ url 'create' %}" onclick="history.back();return false;">Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>

)

[charts/base-cluster/ci/deadmansswitch-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } </script>

    <script>
        
        
    </script>
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id="container">
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters. Your submission is 1,975,745
    <hr>
    <p>
        Something unexpected? Please create a <a href="https://dpaste.freshdesk.com/support/tickets/new">support ticket</a>.
    </p>
</div>
<p>
    <a class="button" href="{$ url 'create' %}" onclick="history.back();return false;">Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>

)

[charts/base-cluster/ci/monitoring-oidc-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } </script>

    <script>
        
        
    </script>
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id="container">
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters. Your submission is 1,969,763
    <hr>
    <p>
        Something unexpected? Please create a <a href="https://dpaste.freshdesk.com/support/tickets/new">support ticket</a>.
    </p>
</div>
<p>
    <a class="button" href="{$ url 'create' %}" onclick="history.back();return false;">Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>

)

[charts/base-cluster/ci/basic-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } </script>

    <script>
        
        
    </script>
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id="container">
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters. Your submission is 1,970,396
    <hr>
    <p>
        Something unexpected? Please create a <a href="https://dpaste.freshdesk.com/support/tickets/new">support ticket</a>.
    </p>
</div>
<p>
    <a class="button" href="{$ url 'create' %}" onclick="history.back();return false;">Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>

)

[charts/base-cluster/ci/monitoring-oidc-ingress-disabled-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } </script>

    <script>
        
        
    </script>
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id="container">
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters. Your submission is 1,988,871
    <hr>
    <p>
        Something unexpected? Please create a <a href="https://dpaste.freshdesk.com/support/tickets/new">support ticket</a>.
    </p>
</div>
<p>
    <a class="button" href="{$ url 'create' %}" onclick="history.back();return false;">Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>

)

[charts/base-cluster/ci/limitrange-resourcequota-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } </script>

    <script>
        
        
    </script>
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id="container">
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters. Your submission is 1,993,489
    <hr>
    <p>
        Something unexpected? Please create a <a href="https://dpaste.freshdesk.com/support/tickets/new">support ticket</a>.
    </p>
</div>
<p>
    <a class="button" href="{$ url 'create' %}" onclick="history.back();return false;">Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>

)

[charts/base-cluster/ci/velero-backupStorageLocations-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } </script>

    <script>
        
        
    </script>
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id="container">
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters. Your submission is 2,020,078
    <hr>
    <p>
        Something unexpected? Please create a <a href="https://dpaste.freshdesk.com/support/tickets/new">support ticket</a>.
    </p>
</div>
<p>
    <a class="button" href="{$ url 'create' %}" onclick="history.back();return false;">Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>

)

charts/base-cluster/values.yaml

changes implemented

🤖 I have created a release *beep* *boop* --- ## [5.0.0](base-cluster-4.12.0...base-cluster-v5.0.0) (2024-02-10) ### ⚠ BREAKING CHANGES * **base-cluster/backup:** only enable velero if a backupstoragelocation is set ([#763](#763)) ### Features * **base-cluster/grafana:** add dashboards for namespace monitoring ([#712](#712)) ([1651273](1651273)) * **base-cluster/limitrange-quotas:** add limitrange and resource quota ([#673](#673)) ([f0ac4c2](f0ac4c2)) ### Bug Fixes * **base-cluster/backup:** only enable velero if a backupstoragelocation is set ([#763](#763)) ([4dfec43](4dfec43)), closes [#752](#752) * **base-cluster/cert-manager:** set higher resource quota for cert-ma… ([#742](#742)) ([53a51bb](53a51bb)) ### Miscellaneous Chores * **base-cluster/artifacthub-images:** Update ArtifactHUB images ([#720](#720)) ([e77941e](e77941e)) * **base-cluster/artifacthub-images:** Update ArtifactHUB images ([#735](#735)) ([45842f3](45842f3)) * **base-cluster/artifacthub-images:** Update ArtifactHUB images ([#738](#738)) ([c83ff3e](c83ff3e)) * **base-cluster/artifacthub-images:** Update ArtifactHUB images ([#744](#744)) ([b8d4d2f](b8d4d2f)) * **base-cluster/artifacthub-images:** Update ArtifactHUB images ([#746](#746)) ([3da1a81](3da1a81)) * **base-cluster/artifacthub-images:** Update ArtifactHUB images ([#747](#747)) ([72978e3](72978e3)) * **base-cluster/artifacthub-images:** Update ArtifactHUB images ([#748](#748)) ([92b09a1](92b09a1)) * **base-cluster/artifacthub-images:** Update ArtifactHUB images ([#749](#749)) ([b53bd86](b53bd86)) * **base-cluster/artifacthub-images:** Update ArtifactHUB images ([#750](#750)) ([feb6630](feb6630)) * **base-cluster/artifacthub-images:** Update ArtifactHUB images ([#760](#760)) ([4b0dac4](4b0dac4)) * **base-cluster/artifacthub-images:** Update ArtifactHUB images ([#761](#761)) ([6515b38](6515b38)) * **base-cluster/artifacthub-images:** Update ArtifactHUB images ([#762](#762)) ([dd58442](dd58442)) * **base-cluster/artifacthub-images:** Update ArtifactHUB images ([#765](#765)) ([cf7f587](cf7f587)) * **base-cluster/artifacthub-images:** Update ArtifactHUB images ([#775](#775)) ([5837439](5837439)) * **base-cluster/artifacthub-images:** Update ArtifactHUB images ([#776](#776)) ([5c04406](5c04406)) * **base-cluster/dependencies:** update docker.io/bitnami/kubectl docker tag to v1.29.1 ([#726](#726)) ([11fa033](11fa033)) * **base-cluster/dependencies:** update helm release common to v2.14.1 ([#692](#692)) ([c570d70](c570d70)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

tasches added the bug Something isn't working label Feb 5, 2024

tasches self-assigned this Feb 5, 2024

tasches requested review from cwrau, marvinWolff and teutonet-bot as code owners February 5, 2024 07:13

github-actions bot added the base-cluster label Feb 5, 2024

cwrau previously requested changes Feb 5, 2024

View reviewed changes

charts/base-cluster/templates/backup/credentials.yaml Outdated Show resolved Hide resolved

charts/base-cluster/templates/backup/validation.yaml Outdated Show resolved Hide resolved

charts/base-cluster/values.yaml Outdated Show resolved Hide resolved

tasches force-pushed the fix/disable-velero-per-default branch 2 times, most recently from bfbbd19 to 02e797d Compare February 5, 2024 09:59

tasches changed the title ~~fix(base-cluster): disable velero per default. Add backupstoragelocation validation~~ fix(base-cluster/backup)!: only enable velero if a backupstoragelocation is set Feb 5, 2024

tasches requested a review from cwrau February 5, 2024 10:40

tasches force-pushed the fix/disable-velero-per-default branch from e3806e1 to 04724b4 Compare February 5, 2024 10:55

tasches force-pushed the fix/disable-velero-per-default branch from b73e9fd to a1253c5 Compare February 7, 2024 13:28

tasches added 7 commits February 7, 2024 16:21

fix(base-cluster/backup)!: only enable velero if a backupstoragelocat…

3612471

…ion is set

fix(base-cluster): adjust values and schema of velero

0bebb82

feat(base-cluster/docs): update documentation for upgrade procedure

bc16e63

fix(base-clsuter): replace backup.enabled condition

a250b0e

fix(base-cluster/backup): changed condition for backup namespace

2f1ab65

creation

fix(base-cluster/backup): fix velero helmrepo creation

4df4bce

feat(base-cluster/backup): update values schema

0f4b3fa

tasches force-pushed the fix/disable-velero-per-default branch from 865a8a3 to 0f4b3fa Compare February 7, 2024 15:22

tasches enabled auto-merge (squash) February 8, 2024 12:00

marvinWolff reviewed Feb 9, 2024

View reviewed changes

charts/base-cluster/values.yaml Show resolved Hide resolved

marvinWolff approved these changes Feb 9, 2024

View reviewed changes

tasches merged commit 4dfec43 into main Feb 9, 2024
11 checks passed

tasches deleted the fix/disable-velero-per-default branch February 9, 2024 12:11

teutonet-bot mentioned this pull request Feb 9, 2024

chore(main): [bot] release base-cluster:5.0.0 #721

Merged

This was referenced Feb 12, 2024

chore(main): [bot] release base-cluster:5.0.1 #778

Merged

chore(main): [bot] release base-cluster:6.0.0 #780

Merged

This was referenced Apr 22, 2024

chore(main): [bot] release base-cluster:6.1.1 #889

Merged

chore(main): [bot] release base-cluster:6.1.3 #896

Merged

chore(main): [bot] release base-cluster:6.1.4 #899

Merged

chore(main): [bot] release base-cluster:6.2.0 #902

Merged

teutonet-bot mentioned this pull request Jun 21, 2024

chore(main): [bot] release base-cluster:6.4.0 #998

Merged

teutonet-bot mentioned this pull request Jul 4, 2024

chore(main): [bot] release base-cluster:6.5.1 #1019

Merged

teutonet-bot mentioned this pull request Jul 17, 2024

chore(main): [bot] release base-cluster:6.6.0 #1043

Merged

teutonet-bot mentioned this pull request Jul 31, 2024

chore(main): [bot] release base-cluster:6.6.1 #1057

Merged

teutonet-bot mentioned this pull request Aug 21, 2024

chore(main): [bot] release base-cluster:6.7.0 #1121

Merged

teutonet-bot mentioned this pull request Sep 3, 2024

chore(main): [bot] release base-cluster:7.0.0 #1166

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(base-cluster/backup)!: only enable velero if a backupstoragelocation is set #763

fix(base-cluster/backup)!: only enable velero if a backupstoragelocation is set #763

tasches commented Feb 5, 2024

marvinWolff commented Feb 5, 2024

cwrau commented Feb 5, 2024

cwrau commented Feb 7, 2024

teutonet-bot commented Feb 7, 2024

fix(base-cluster/backup)!: only enable velero if a backupstoragelocation is set #763

fix(base-cluster/backup)!: only enable velero if a backupstoragelocation is set #763

Conversation

tasches commented Feb 5, 2024

marvinWolff commented Feb 5, 2024

cwrau commented Feb 5, 2024

cwrau commented Feb 7, 2024

teutonet-bot commented Feb 7, 2024

🤖 I have diffed this beep boop

"/$namespace/$kind/$name.yaml" for normal resources "/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive 'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease

"/$namespace/$kind/$name.yaml" for normal resources
"/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive
'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease