-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(base-cluster/monitoring): fix most of resource linting errors #741
base: main
Are you sure you want to change the base?
Conversation
From 177 to 77. |
5452b73
to
bf5f617
Compare
🤖 I have diffed this beep boop"/$namespace/$kind/$name.yaml" for normal resources
|
Since #835 is on the way, you should also do it that way, to have a uniform way to handle resources |
Base branch was modified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since #835 has been merged, you should also do it that way, to have a uniform way to handle resources
Ah yes, you're right. Will update this. |
bf5f617
to
53cc66d
Compare
# Conflicts: # charts/base-cluster/templates/descheduler/descheduler.yaml # charts/base-cluster/templates/flux/_create-authentication-key-secret-job.yaml # charts/base-cluster/templates/global/prevent-uninstallation.yaml # charts/base-cluster/templates/monitoring/deadMansSwitch/registration.yaml # charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml
8eb867e
to
b007111
Compare
b007111
to
b0f9169
Compare
🤖 I have diffed this beep boop"/$namespace/$kind/$name.yaml" for normal resources
|
charts/base-cluster/templates/flux/_create-authentication-key-secret-job.yaml
Outdated
Show resolved
Hide resolved
charts/base-cluster/templates/flux/_create-authentication-key-secret-job.yaml
Outdated
Show resolved
Hide resolved
resources: | ||
requests: | ||
memory: 256Mi | ||
limits: | ||
memory: 4Gi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably remove accidentaly.
Will re-add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah no, no accident.
I miss placed it before. According to the values, resources
is a top level key of the values: https://github.com/aquasecurity/trivy/blob/main/helm/trivy/values.yaml#L21
…secret-job.yaml Co-authored-by: Chris Werner Rau <[email protected]>
…secret-job.yaml Co-authored-by: Chris Werner Rau <[email protected]>
Co-authored-by: Chris Werner Rau <[email protected]>
Co-authored-by: Chris Werner Rau <[email protected]>
Ref.: #687
This fixes most of the linting errors regarding resources.
Some values may need some more tweaking, as it's hard to guess what for example jobs need, as they're gone blazing fast.
Also some resources i was unable to set. I need to look this up further.