fix(base-cluster/ingress): fix templating when no baseDomain is set #647

cwrau · 2023-11-23T14:50:08Z

No description provided.

teutonet-bot · 2023-11-23T14:56:00Z

🤖 I have diffed this beep boop

"/$namespace/$kind/$name.yaml" for normal resources
"/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive
'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease

charts/base-cluster/ci/monitoring-ingress-unauthenticated-values.yaml has no changes

[charts/base-cluster/ci/rbac-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } $(document).keypress(function(event) { if (key(event, 'N') && window.location.pathname != "/") { document.location = "/" } }) </script>

    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id='container'>
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters.
    <hr>
    <p>
        Something unexpected? Please create a <a href='https://dpaste.freshdesk.com/support/tickets/new'>support ticket</a>.
    </p>
</div>
<p>
    <a class='button' href='/' onclick='history.back();return false;'>Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>

)

charts/base-cluster/ci/imagepullsecrets-values.yaml has no changes

charts/base-cluster/values.yaml has no changes

[charts/base-cluster/ci/artifacthub-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } $(document).keypress(function(event) { if (key(event, 'N') && window.location.pathname != "/") { document.location = "/" } }) </script>

    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id='container'>
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters.
    <hr>
    <p>
        Something unexpected? Please create a <a href='https://dpaste.freshdesk.com/support/tickets/new'>support ticket</a>.
    </p>
</div>
<p>
    <a class='button' href='/' onclick='history.back();return false;'>Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>

)

[charts/base-cluster/ci/disabled-ingress-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } $(document).keypress(function(event) { if (key(event, 'N') && window.location.pathname != "/") { document.location = "/" } }) </script>

    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id='container'>
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters.
    <hr>
    <p>
        Something unexpected? Please create a <a href='https://dpaste.freshdesk.com/support/tickets/new'>support ticket</a>.
    </p>
</div>
<p>
    <a class='button' href='/' onclick='history.back();return false;'>Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>

)

[charts/base-cluster/ci/flux-gitrepositories-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } $(document).keypress(function(event) { if (key(event, 'N') && window.location.pathname != "/") { document.location = "/" } }) </script>

    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id='container'>
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters.
    <hr>
    <p>
        Something unexpected? Please create a <a href='https://dpaste.freshdesk.com/support/tickets/new'>support ticket</a>.
    </p>
</div>
<p>
    <a class='button' href='/' onclick='history.back();return false;'>Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>

)

charts/base-cluster/ci/priorityclasses-values.yaml has no changes

charts/base-cluster/ci/monitoring-oidc-values.yaml has no changes

charts/base-cluster/ci/basic-values.yaml has no changes

[charts/base-cluster/ci/monitoring-oidc-ingress-disabled-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } $(document).keypress(function(event) { if (key(event, 'N') && window.location.pathname != "/") { document.location = "/" } }) </script>

    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id='container'>
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters.
    <hr>
    <p>
        Something unexpected? Please create a <a href='https://dpaste.freshdesk.com/support/tickets/new'>support ticket</a>.
    </p>
</div>
<p>
    <a class='button' href='/' onclick='history.back();return false;'>Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>

)

[charts/base-cluster/ci/velero-backupStorageLocations-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } $(document).keypress(function(event) { if (key(event, 'N') && window.location.pathname != "/") { document.location = "/" } }) </script>

    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id='container'>
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters.
    <hr>
    <p>
        Something unexpected? Please create a <a href='https://dpaste.freshdesk.com/support/tickets/new'>support ticket</a>.
    </p>
</div>
<p>
    <a class='button' href='/' onclick='history.back();return false;'>Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>

)

fix(base-cluster/ingress): fix templating when no baseDomain is set

4e0a5f4

cwrau requested review from marvinWolff and tasches as code owners November 23, 2023 14:50

cwrau enabled auto-merge (squash) November 23, 2023 14:50

github-actions bot assigned cwrau Nov 23, 2023

github-actions bot added the base-cluster label Nov 23, 2023

tasches approved these changes Nov 23, 2023

View reviewed changes

cwrau merged commit 46dae44 into main Nov 23, 2023
9 checks passed

cwrau deleted the fix/base-cluster-ingress-without-basedomain branch November 23, 2023 15:38

teutonet-bot mentioned this pull request Nov 23, 2023

chore(main): [bot] release base-cluster:4.11.0 #646

Merged

teutonet-bot mentioned this pull request Jan 18, 2024

chore(main): [bot] release base-cluster:5.0.0 #721

Merged

This was referenced Feb 12, 2024

chore(main): [bot] release base-cluster:5.0.1 #778

Merged

chore(main): [bot] release base-cluster:6.0.0 #780

Merged

This was referenced Apr 22, 2024

chore(main): [bot] release base-cluster:6.1.1 #889

Merged

chore(main): [bot] release base-cluster:6.1.3 #896

Merged

chore(main): [bot] release base-cluster:6.1.4 #899

Merged

chore(main): [bot] release base-cluster:6.2.0 #902

Merged

teutonet-bot mentioned this pull request Jun 21, 2024

chore(main): [bot] release base-cluster:6.4.0 #998

Merged

teutonet-bot mentioned this pull request Jul 4, 2024

chore(main): [bot] release base-cluster:6.5.1 #1019

Merged

teutonet-bot mentioned this pull request Jul 17, 2024

chore(main): [bot] release base-cluster:6.6.0 #1043

Merged

teutonet-bot mentioned this pull request Jul 31, 2024

chore(main): [bot] release base-cluster:6.6.1 #1057

Merged

teutonet-bot mentioned this pull request Aug 21, 2024

chore(main): [bot] release base-cluster:6.7.0 #1121

Merged

teutonet-bot mentioned this pull request Sep 3, 2024

chore(main): [bot] release base-cluster:7.0.0 #1166

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(base-cluster/ingress): fix templating when no baseDomain is set #647

fix(base-cluster/ingress): fix templating when no baseDomain is set #647

cwrau commented Nov 23, 2023

teutonet-bot commented Nov 23, 2023

fix(base-cluster/ingress): fix templating when no baseDomain is set #647

fix(base-cluster/ingress): fix templating when no baseDomain is set #647

Conversation

cwrau commented Nov 23, 2023

teutonet-bot commented Nov 23, 2023

🤖 I have diffed this beep boop

"/$namespace/$kind/$name.yaml" for normal resources "/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive 'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease

"/$namespace/$kind/$name.yaml" for normal resources
"/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive
'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease