Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci/license-check): check if specifed images have been manually l… #1203

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

marvinWolff
Copy link
Collaborator

…icense checked

Also fixed title of job.

This will fix the problem with trivy, that the licenses of the software in an docker-image are ok, and not if the docker-image itself is ok.

The list will contain every image used by us and check, if an image used by us is not in this list.

@marvinWolff marvinWolff requested a review from a team as a code owner October 9, 2024 10:34
@marvinWolff marvinWolff requested a review from SyeKlu October 9, 2024 10:34
@marvinWolff marvinWolff self-assigned this Oct 9, 2024
@marvinWolff marvinWolff requested review from tasches and cwrau and removed request for SyeKlu October 9, 2024 10:34
@marvinWolff marvinWolff force-pushed the feat/ci/check_license_list branch from 60ae79d to ee1cdff Compare October 9, 2024 12:28
@marvinWolff marvinWolff force-pushed the feat/ci/check_license_list branch from ee1cdff to 0909974 Compare October 9, 2024 12:40
@marvinWolff marvinWolff force-pushed the feat/ci/check_license_list branch from 0909974 to 5300f56 Compare October 9, 2024 14:23
.github/workflows/check-licenses.yaml Outdated Show resolved Hide resolved
.github/scripts/licenseList Outdated Show resolved Hide resolved
cwrau
cwrau previously requested changes Oct 30, 2024
.github/workflows/check-licenses.yaml Outdated Show resolved Hide resolved
.github/licenseList.yaml Outdated Show resolved Hide resolved
tasches
tasches previously approved these changes Nov 18, 2024
@cwrau cwrau force-pushed the feat/ci/check_license_list branch from 2d6c97d to 8893460 Compare November 18, 2024 14:04
@cwrau cwrau self-requested a review November 18, 2024 14:42
@cwrau cwrau dismissed their stale review November 18, 2024 14:43

I fixed it myself

@cwrau cwrau requested a review from tasches November 18, 2024 14:43
@cwrau cwrau removed their request for review November 18, 2024 14:43
@marvinWolff marvinWolff merged commit 328cc04 into main Nov 18, 2024
7 checks passed
@marvinWolff marvinWolff deleted the feat/ci/check_license_list branch November 18, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants