fix(base-cluster/kube-prometheus-stack): only register healthcheck if enabled on both sides #1052

<title> Error </title> <script src="https://unpkg.com/[email protected]/dist/htmx.min.js"></script> <script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.7.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } </script> <script>

    </script>
    <style></style>
    
    
</head>

<body hx-on="keydown: var path=window.location.pathname; if ((event.key=='n' || event.key=='N') && path && path !== '/' && !path.includes('/duplicate/') && !path.includes('/dashboard/') && !path.includes('/accounts/') && !path.includes('/properties/')) { window.location.href = '/'; }">
    <div id="container">
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste (shortcut: 'N')" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help/"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about/"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters. Your submission is 1,912,840. Your IP will be blocked if you exceed this limit again in the next 60 seconds.
    <hr>
    <p>
        Something unexpected? Please create a <a href="https://dpaste.freshdesk.com/support/tickets/new">support ticket</a>.
    </p>
</div>
<p>
    <a class="button" href="{$ url 'create' %}" onclick="history.back();return false;">Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>

)

charts/base-cluster/ci/monitoring-oidc-values.yaml

charts/base-cluster/ci/basic-values.yaml has no changes

charts/base-cluster/ci/monitoring-oidc-ingress-disabled-values.yaml

charts/base-cluster/ci/limitrange-resourcequota-values.yaml

charts/base-cluster/templates/monitoring/deadMansSwitch/registration.yaml

… enabled on both sides

cwrau requested review from marvinWolff, tasches, teutonet-bot and a team as code owners July 29, 2024 11:39

cwrau enabled auto-merge (squash) July 29, 2024 11:39

github-actions bot assigned cwrau Jul 29, 2024

github-actions bot added the base-cluster label Jul 29, 2024

tasches requested changes Aug 27, 2024

View reviewed changes

cwrau force-pushed the fix/base-cluster/healthchecks branch from a3640a3 to 5d4e601 Compare August 27, 2024 14:45

cwrau requested a review from tasches August 29, 2024 12:37

tasches requested changes Aug 30, 2024

View reviewed changes

charts/base-cluster/templates/monitoring/deadMansSwitch/registration.yaml Show resolved Hide resolved

cwrau force-pushed the fix/base-cluster/healthchecks branch from 9cfc86b to 2e03632 Compare September 3, 2024 13:38

tasches self-requested a review November 18, 2024 14:47

tasches previously approved these changes Nov 18, 2024

View reviewed changes

cwrau disabled auto-merge November 26, 2024 08:45

teutonet-bot previously approved these changes Nov 26, 2024

View reviewed changes

cwrau enabled auto-merge (squash) November 26, 2024 08:47

marvinWolff previously approved these changes Nov 26, 2024

View reviewed changes

cwrau added 2 commits November 26, 2024 10:15

fix(base-cluster/kube-prometheus-stack): only register healthcheck if…

cc39f4a

… enabled on both sides

fix(base-cluster/deadMansSwitch)!: only setup with baseDomain

4fa9759

cwrau dismissed stale reviews from marvinWolff, teutonet-bot, and tasches via 4fa9759 November 26, 2024 09:15

cwrau force-pushed the fix/base-cluster/healthchecks branch from 2e03632 to 4fa9759 Compare November 26, 2024 09:15

auto-merge was automatically disabled November 26, 2024 09:19
Pull Request is not mergeable

marvinWolff approved these changes Dec 2, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(base-cluster/kube-prometheus-stack): only register healthcheck if enabled on both sides #1052

fix(base-cluster/kube-prometheus-stack): only register healthcheck if enabled on both sides #1052

cwrau commented Jul 29, 2024

teutonet-bot commented Jul 29, 2024

tasches left a comment

teutonet-bot commented Aug 27, 2024 •

edited

Loading

fix(base-cluster/kube-prometheus-stack): only register healthcheck if enabled on both sides #1052

Are you sure you want to change the base?

fix(base-cluster/kube-prometheus-stack): only register healthcheck if enabled on both sides #1052

Conversation

cwrau commented Jul 29, 2024

teutonet-bot commented Jul 29, 2024

🤖 I have diffed this beep boop

"/$namespace/$kind/$name.yaml" for normal resources "/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive 'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease

tasches left a comment

Choose a reason for hiding this comment

teutonet-bot commented Aug 27, 2024 • edited Loading

🤖 I have diffed this beep boop

"/$namespace/$kind/$name.yaml" for normal resources "/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive 'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease

"/$namespace/$kind/$name.yaml" for normal resources
"/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive
'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease

teutonet-bot commented Aug 27, 2024 •

edited

Loading

"/$namespace/$kind/$name.yaml" for normal resources
"/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive
'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease