Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates site manifest and e2e for 1.12.1 release #82

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

danehans
Copy link

Updates the site manifest and e2e tests to support the 1.12.1 release.

Fixes #81

Signed-off-by: danehans [email protected]

@danehans danehans requested review from deva26 and mathetake January 14, 2022 19:28
@danehans danehans force-pushed the issue_81 branch 2 times, most recently from f77ef41 to b9c7022 Compare January 14, 2022 19:56
@danehans danehans force-pushed the issue_81 branch 2 times, most recently from 0042da4 to 0ca8498 Compare January 14, 2022 20:15
if strings.Contains(ver, "1.12.1") {
flavor = "v1"
}
require.Contains(t, buf.String(), fmt.Sprintf(`-tetrate-%s now`, flavor))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to retain the canonical way -tetrate-v0

{
"version": "1.12.1",
"flavor": "tetrate",
"flavor_version": 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.12.1 - Did we have a v0 release already?

Copy link
Author

@danehans danehans Jan 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deva26 a v0 was tagged but never built. A v1 was tagged, I believe by @yskopets, which I used to build the images. Should I build images based on the v0 tag so we have both v0 and v1 flavors or should I build v0 images based on the v1 tag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 1.12.1 Support
2 participants