forked from Azure/azure-rest-api-specs
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNR brInfo_breaking_change
branch
#3340
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to mergeNext steps that must be taken to merge this PR:
|
Swagger Generation Artifacts
|
Generated ApiView
|
Swagger Validation Report
|
Compared specs (v0.10.8) | new version | base version |
---|---|---|
agfood.json | 2020-05-12-preview(7857abe) | 2020-05-12-preview(main) |
Rule | Message |
---|---|
1008 - ModifiedOperationId |
The operation id has been changed from 'Extensions_Create' to 'Extensions_Create2'. This will impact generated code. New: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L10:7 Old: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L10:7 |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️
LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.1) | new version | base version |
---|---|---|
package-2020-05-12-preview | package-2020-05-12-preview(7857abe) | package-2020-05-12-preview(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️️✔️
[ignore this check status; not blocking PR merge] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
[ignore this check status; not blocking PR merge] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
PR Summary succeeded [Detail] [Expand]
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
This was referenced Apr 30, 2024
konrad-jamrozik
added
BreakingChange-Approved-BranchPolicyException
Changes violate the branch policy but exception has been granted. aka.ms/azsdk/pr-brch-deep
and removed
NotReadyForARMReview
labels
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMReview
BreakingChange-Approved-BranchPolicyException
Changes violate the branch policy but exception has been granted. aka.ms/azsdk/pr-brch-deep
BreakingChange-Go-Sdk
BreakingChangeReviewRequired
ReadyForApiTest
resource-manager
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT REVIEW! This is a test PR created by kojamroz from branch
brInfo_breaking_change
.Information about this PR extracted from
BRANCH_INFO.md
This branch was created by kojamroz on 4/9/2024.
It differs from main as follows:
It modifies
specification/agrifood/resource-manager/Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json
by introducing a breaking change:
"operationId": "Extensions_Create",
changed to
"operationId": "Extensions_Create2",