Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agfood.json #3329

Closed
wants to merge 7 commits into from
Closed

Update agfood.json #3329

wants to merge 7 commits into from

Conversation

konrad-jamrozik
Copy link

@konrad-jamrozik konrad-jamrozik commented Apr 25, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app-test bot commented Apr 25, 2024

Next Steps to merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview).
    To allow merging, this PR must get ARMSignedOff label from an ARM reviewer.
    This PR has NotReadyForARMReview label. This happens if your PR has one of these labels without corresponding approvals:
    BreakingChangeReviewRequired, VersioningReviewRequired, CI-NewRPNamespaceWithoutRPaaS, CI-RpaaSRPNotInPrivateRepo.
    Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking labels are removed or approved, add to your PR a comment with contents /azp run.
    Automation will re-evaluate your PR and if everything looks good, it will add WaitForARMFeedback label which will put your PR on the ARM review queue.
    For details, see [aka.ms/azsdk/pr-arm-review](https://aka.ms/azsdk/pr-arm-review).
  • ❌ Your PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock your PR, follow [aka.ms/brch](https://aka.ms/brch) to get the required approvals. ( test `code`) (test2 `code`) NaN
  • ❌ The required check named Swagger BreakingChange has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it. In addition, refer to step 1 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Copy link

openapi-pipeline-app-test bot commented Apr 25, 2024

Swagger Generation Artifacts

️🔄[ignore this check status; not blocking PR merge] ApiDocPreview inProgress [Detail]
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning in generating from 9b754e98b388642b149baf217a80a212a7d6ab71. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh]
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.5.0 -> 10.6.0
    cmderr	[automation_init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.6.0>
    cmderr	[automation_init.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_init.sh] npm notice
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-agrifood [Preview SDK Changes]
    • azure_mgmt_agrifood-1.0.0b1-py3-none-any.whl
    • azure-mgmt-agrifood-1.0.0b1.zip
️⚠️ azure-sdk-for-go warning [Detail]
  • ⚠️Warning in generating from 9b754e98b388642b149baf217a80a212a7d6ab71. SDK Automation 14.0.0
    Only showing 120 items here. Refer to log for details.
    cmderr	[automation_init.sh]  64150K . 95%  139M 0s
    cmderr	[automation_init.sh]  64200K .......... 95%  160M 0s
    cmderr	[automation_init.sh]  64250K .....
    cmderr	[automation_init.sh]  64300K ..... 95%  153M 0s
    cmderr	[automation_init.sh]  64350K. 95%  139M 0s
    cmderr	[automation_init.sh]  64400K 0s
    cmderr	[automation_init.sh]  64450K .....  169M 0s
    cmderr	[automation_init.sh]  64500K .......... 95%  159M 0s
    cmderr	[automation_init.sh]  64550K .. 95%  136M 0s
    cmderr	[automation_init.sh]  64600K .......  158M 0s
    cmderr	[automation_init.sh]  64650K .... 96%  169M 0s
    cmderr	[automation_init.sh]  64700K .... 96%  168M 0s
    cmderr	[automation_init.sh]  64750K .. 96%  134M 0s
    cmderr	[automation_init.sh]  64800K ....... 0s
    cmderr	[automation_init.sh]  64850K ..... 0s
    cmderr	[automation_init.sh]  64900K .......... 96%  170M 0s
    cmderr	[automation_init.sh]  64950K ............... 96%  138M 0s
    cmderr	[automation_init.sh]  65000K ......... 96%  152M 0s
    cmderr	[automation_init.sh]  65050K .. 96%  165M 0s
    cmderr	[automation_init.sh]  65100K 96%  163M 0s
    cmderr	[automation_init.sh]  65150K .. 96%  146M 0s
    cmderr	[automation_init.sh]  65200K ... 96%  162M 0s
    cmderr	[automation_init.sh]  65250K .......... 96%  150M 0s
    cmderr	[automation_init.sh]  65300K .......... ........ 96%  156M 0s
    cmderr	[automation_init.sh]  65350K .. 97%  154M 0s
    cmderr	[automation_init.sh]  65400K . .......... 97%  169M 0s
    cmderr	[automation_init.sh]  65450K ..... 97%  160M 0s
    cmderr	[automation_init.sh]  65500K ... 97%  160M 0s
    cmderr	[automation_init.sh]  65550K .. 97%  145M 0s
    cmderr	[automation_init.sh]  65600K .... 97%  174M 0s
    cmderr	[automation_init.sh]  65650K..... 97%  161M 0s
    cmderr	[automation_init.sh]  65700K .......... 97%  153M 0s
    cmderr	[automation_init.sh]  65750K .. 97%  131M 0s
    cmderr	[automation_init.sh]  65800K  170M 0s
    cmderr	[automation_init.sh]  65850K ...  177M 0s
    cmderr	[automation_init.sh]  65900K ...  173M 0s
    cmderr	[automation_init.sh]  65950K .. 97%  140M 0s
    cmderr	[automation_init.sh]  66000K .... 98%  176M 0s
    cmderr	[automation_init.sh]  66050K  172M 0s
    cmderr	[automation_init.sh]  66100K ...  171M 0s
    cmderr	[automation_init.sh]  66150K .
    cmderr	[automation_init.sh]  66200K ........ 98%  173M 0s
    cmderr	[automation_init.sh]  66250K
    cmderr	[automation_init.sh]  66300K ..... 98%  164M 0s
    cmderr	[automation_init.sh]  66350K . 98%  146M 0s
    cmderr	[automation_init.sh]  66400K .
    cmderr	[automation_init.sh]  66450K .....
    cmderr	[automation_init.sh]  66500K ...  167M 0s
    cmderr	[automation_init.sh]  66550K .. 98%  152M 0s
    cmderr	[automation_init.sh]  66600K   167M 0s
    cmderr	[automation_init.sh]  66650K .....  166M 0s
    cmderr	[automation_init.sh]  66700K ... 0s
    cmderr	[automation_init.sh]  66750K .. 99%  140M 0s
    cmderr	[automation_init.sh]  66800K
    cmderr	[automation_init.sh]  66850K ..... 0s
    cmderr	[automation_init.sh]  66900K .......... ........ 99%  178M 0s
    cmderr	[automation_init.sh]  66950K .......... ........... 99%  156M 0s
    cmderr	[automation_init.sh]  67000K ........ .......... .......... 99%  173M 0s
    cmderr	[automation_init.sh]  67050K .......... .......... . 99%  185M 0s
    cmderr	[automation_init.sh]  67100K ...... .......... .......... 99%  172M 0s
    cmderr	[automation_init.sh]  67150K .......... .......... ...... 99%  164M 0s
    cmderr	[automation_init.sh]  67200K ............... .......... 99%  179M 0s
    cmderr	[automation_init.sh]  67250K .......... .......... .......... .......... .......... 99%  185M 0s
    cmderr	[automation_init.sh]  67300K .... .......... .......... 99%  176M 0s
    cmderr	[automation_init.sh]  67350K .......... .......... .                               100%  185M=0.4s
    cmderr	[automation_init.sh] 2024-04-29 22:51:37 (156 MB/s) - 'go1.22.0.linux-amd64.tar.gz' saved [68988925/68988925]
    cmderr	[automation_init.sh] + tar -C /tmp -xzf go1.22.0.linux-amd64.tar.gz
    cmderr	[automation_init.sh] + export GOROOT=/tmp/go
    cmderr	[automation_init.sh] + export PATH=/tmp/go/bin:/mnt/vss/_work/1/a/unified-pipeline-runtime/private/azure-rest-api-specs-pipeline/node_modules/.bin:/opt/hostedtoolcache/Python/3.10.14/x64/bin:/opt/hostedtoolcache/Python/3.10.14/x64:/opt/hostedtoolcache/node/18.20.2/x64/bin:/snap/bin:/home/cloudtest/.local/bin:/opt/pipx_bin:/home/cloudtest/.cargo/bin:/home/cloudtest/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/cloudtest/.dotnet/tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
    cmderr	[automation_init.sh] + dirname ./eng/scripts/automation_init.sh
    cmderr	[automation_init.sh] + cd ./eng/scripts
    cmderr	[automation_init.sh] + pwd
    cmderr	[automation_init.sh] + DIRECTORY=/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/eng/scripts
    cmderr	[automation_init.sh] + [  =  ]
    cmderr	[automation_init.sh] + realpath /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/eng/scripts/../../../
    cmderr	[automation_init.sh] + WORKFOLDER=/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure
    cmderr	[automation_init.sh] + echo /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure
    cmderr	[automation_init.sh] + export GOPATH=/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/gofolder
    cmderr	[automation_init.sh] + [ ! -d /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/gofolder/bin ]
    cmderr	[automation_init.sh] + echo create gopath folder
    cmderr	[automation_init.sh] + mkdir -p /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/gofolder/bin
    cmderr	[automation_init.sh] + echo /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/gofolder
    cmderr	[automation_init.sh] + export GO111MODULE=on
    cmderr	[automation_init.sh] + realpath /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/eng/scripts/../tools/generator
    cmderr	[automation_init.sh] + generatorDirectory=/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/eng/tools/generator
    cmderr	[automation_init.sh] + cd /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/eng/tools/generator
    cmderr	[automation_init.sh] + go build
    cmderr	[automation_init.sh] go: downloading github.com/spf13/cobra v1.8.0
    cmderr	[automation_init.sh] go: downloading github.com/google/go-github/v53 v53.2.0
    cmderr	[automation_init.sh] go: downloading github.com/spf13/pflag v1.0.5
    cmderr	[automation_init.sh] go: downloading github.com/Azure/azure-sdk-for-go/eng/tools/internal v0.0.0-20240319034639-2647d4f75389
    cmderr	[automation_init.sh] go: downloading github.com/ahmetb/go-linq/v3 v3.2.0
    cmderr	[automation_init.sh] go: downloading github.com/go-git/go-git/v5 v5.11.0
    cmderr	[automation_init.sh] go: downloading golang.org/x/oauth2 v0.18.0
    cmderr	[automation_init.sh] go: downloading github.com/Masterminds/semver v1.5.0
    cmderr	[automation_init.sh] go: downloading github.com/ProtonMail/go-crypto v1.0.0
    cmderr	[automation_init.sh] go: downloading github.com/google/go-querystring v1.1.0
    cmderr	[automation_init.sh] go: downloading dario.cat/mergo v1.0.0
    cmderr	[automation_init.sh] go: downloading github.com/go-git/go-billy/v5 v5.5.0
    cmderr	[automation_init.sh] go: downloading github.com/sergi/go-diff v1.3.1
    cmderr	[automation_init.sh] go: downloading github.com/pjbgf/sha1cd v0.3.0
    cmderr	[automation_init.sh] go: downloading github.com/cyphar/filepath-securejoin v0.2.4
    cmderr	[automation_init.sh] go: downloading golang.org/x/sys v0.18.0
    cmderr	[automation_init.sh] go: downloading github.com/go-git/gcfg v1.5.1-0.20230307220236-3a3c6141e376
    cmderr	[automation_init.sh] go: downloading github.com/emirpasic/gods v1.18.1
    cmderr	[automation_init.sh] go: downloading github.com/jbenet/go-context v0.0.0-20150711004518-d14ea06fba99
    cmderr	[automation_init.sh] go: downloading golang.org/x/crypto v0.21.0
    cmderr	[automation_init.sh] go: downloading gopkg.in/warnings.v0 v0.1.2
    cmderr	[automation_init.sh] go: downloading github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da
    cmderr	[automation_init.sh] go: downloading github.com/kevinburke/ssh_config v1.2.0
    cmderr	[automation_init.sh] go: downloading github.com/skeema/knownhosts v1.2.2
    cmderr	[automation_init.sh] go: downloading github.com/xanzy/ssh-agent v0.3.3
    cmderr	[automation_init.sh] go: downloading golang.org/x/net v0.22.0
    cmderr	[automation_init.sh] go: downloading github.com/cloudflare/circl v1.3.7
    cmderr	[automation_init.sh] + cp generator /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/gofolder/bin/
    cmderr	[automation_init.sh] + export PATH=/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/gofolder/bin:/tmp/go/bin:/mnt/vss/_work/1/a/unified-pipeline-runtime/private/azure-rest-api-specs-pipeline/node_modules/.bin:/opt/hostedtoolcache/Python/3.10.14/x64/bin:/opt/hostedtoolcache/Python/3.10.14/x64:/opt/hostedtoolcache/node/18.20.2/x64/bin:/snap/bin:/home/cloudtest/.local/bin:/opt/pipx_bin:/home/cloudtest/.cargo/bin:/home/cloudtest/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/cloudtest/.dotnet/tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
    cmderr	[automation_init.sh] + cd /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/eng/scripts
    cmderr	[automation_init.sh] + cat
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    cmderr	[generator automation-v2] autorest --use=@autorest/[email protected] --go --track2 --output-folder=/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/agrifood/armagrifood --clear-output-folder=false --go.clear-output-folder=false --honor-body-placement=true --remove-unreferenced-types=false ./autorest.md
  • ️✔️sdk/resourcemanager/agrifood/armagrifood [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - `PublicNetworkAccessHybrid` from enum `PublicNetworkAccess` has been removed
    info	[Changelog] - Function `*ClientFactory.NewFarmBeatsExtensionsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewFarmBeatsModelsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewLocationsClient` has been removed
    info	[Changelog] - Function `*ExtensionsClient.Create` has been removed
    info	[Changelog] - Function `*ExtensionsClient.NewListByFarmBeatsPager` has been removed
    info	[Changelog] - Function `*ExtensionsClient.Update` has been removed
    info	[Changelog] - Function `NewFarmBeatsExtensionsClient` has been removed
    info	[Changelog] - Function `*FarmBeatsExtensionsClient.Get` has been removed
    info	[Changelog] - Function `*FarmBeatsExtensionsClient.NewListPager` has been removed
    info	[Changelog] - Function `NewFarmBeatsModelsClient` has been removed
    info	[Changelog] - Function `*FarmBeatsModelsClient.CreateOrUpdate` has been removed
    info	[Changelog] - Function `*FarmBeatsModelsClient.Delete` has been removed
    info	[Changelog] - Function `*FarmBeatsModelsClient.Get` has been removed
    info	[Changelog] - Function `*FarmBeatsModelsClient.GetOperationResult` has been removed
    info	[Changelog] - Function `*FarmBeatsModelsClient.NewListByResourceGroupPager` has been removed
    info	[Changelog] - Function `*FarmBeatsModelsClient.NewListBySubscriptionPager` has been removed
    info	[Changelog] - Function `*FarmBeatsModelsClient.BeginUpdate` has been removed
    info	[Changelog] - Function `NewLocationsClient` has been removed
    info	[Changelog] - Function `*LocationsClient.CheckNameAvailability` has been removed
    info	[Changelog] - Operation `*PrivateEndpointConnectionsClient.NewListByResourcePager` does not support pagination anymore, use `*PrivateEndpointConnectionsClient.ListByResource` instead.
    info	[Changelog] - Operation `*PrivateLinkResourcesClient.NewListByResourcePager` does not support pagination anymore, use `*PrivateLinkResourcesClient.ListByResource` instead.
    info	[Changelog] - Struct `FarmBeats` has been removed
    info	[Changelog] - Struct `FarmBeatsExtension` has been removed
    info	[Changelog] - Struct `FarmBeatsExtensionListResponse` has been removed
    info	[Changelog] - Struct `FarmBeatsExtensionProperties` has been removed
    info	[Changelog] - Struct `FarmBeatsListResponse` has been removed
    info	[Changelog] - Struct `FarmBeatsProperties` has been removed
    info	[Changelog] - Struct `FarmBeatsUpdateProperties` has been removed
    info	[Changelog] - Struct `FarmBeatsUpdateRequestModel` has been removed
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `ProvisioningStateRunning` added to enum type `ProvisioningState`
    info	[Changelog] - New value `PublicNetworkAccessDisabled` added to enum type `PublicNetworkAccess`
    info	[Changelog] - New enum type `AuthCredentialsKind` with values `AuthCredentialsKindAPIKeyAuthCredentials`, `AuthCredentialsKindOAuthClientCredentials`
    info	[Changelog] - New function `*APIKeyAuthCredentials.GetAuthCredentials() *AuthCredentials`
    info	[Changelog] - New function `*AuthCredentials.GetAuthCredentials() *AuthCredentials`
    info	[Changelog] - New function `NewCheckNameAvailabilityClient(string, azcore.TokenCredential, *arm.ClientOptions) (*CheckNameAvailabilityClient, error)`
    info	[Changelog] - New function `*CheckNameAvailabilityClient.CheckNameAvailability(context.Context, CheckNameAvailabilityRequest, *CheckNameAvailabilityClientCheckNameAvailabilityOptions) (CheckNameAvailabilityClientCheckNameAvailabilityResponse, error)`
    info	[Changelog] - New function `*ClientFactory.NewCheckNameAvailabilityClient() *CheckNameAvailabilityClient`
    info	[Changelog] - New function `*ClientFactory.NewDataConnectorsClient() *DataConnectorsClient`
    info	[Changelog] - New function `*ClientFactory.NewDataManagerForAgricultureExtensionsClient() *DataManagerForAgricultureExtensionsClient`
    info	[Changelog] - New function `*ClientFactory.NewDataManagerForAgricultureResourcesClient() *DataManagerForAgricultureResourcesClient`
    info	[Changelog] - New function `*ClientFactory.NewOperationResultsClient() *OperationResultsClient`
    info	[Changelog] - New function `*ClientFactory.NewSolutionsClient() *SolutionsClient`
    info	[Changelog] - New function `*ClientFactory.NewSolutionsDiscoverabilityClient() *SolutionsDiscoverabilityClient`
    info	[Changelog] - New function `NewDataConnectorsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*DataConnectorsClient, error)`
    info	[Changelog] - New function `*DataConnectorsClient.CreateOrUpdate(context.Context, string, string, string, DataConnector, *DataConnectorsClientCreateOrUpdateOptions) (DataConnectorsClientCreateOrUpdateResponse, error)`
    info	[Changelog] - New function `*DataConnectorsClient.Delete(context.Context, string, string, string, *DataConnectorsClientDeleteOptions) (DataConnectorsClientDeleteResponse, error)`
    info	[Changelog] - New function `*DataConnectorsClient.Get(context.Context, string, string, string, *DataConnectorsClientGetOptions) (DataConnectorsClientGetResponse, error)`
    info	[Changelog] - New function `*DataConnectorsClient.NewListPager(string, string, *DataConnectorsClientListOptions) *runtime.Pager[DataConnectorsClientListResponse]`
    info	[Changelog] - New function `NewDataManagerForAgricultureExtensionsClient(azcore.TokenCredential, *arm.ClientOptions) (*DataManagerForAgricultureExtensionsClient, error)`
    info	[Changelog] - New function `*DataManagerForAgricultureExtensionsClient.Get(context.Context, string, *DataManagerForAgricultureExtensionsClientGetOptions) (DataManagerForAgricultureExtensionsClientGetResponse, error)`
    info	[Changelog] - New function `*DataManagerForAgricultureExtensionsClient.NewListPager(*DataManagerForAgricultureExtensionsClientListOptions) *runtime.Pager[DataManagerForAgricultureExtensionsClientListResponse]`
    info	[Changelog] - New function `NewDataManagerForAgricultureResourcesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*DataManagerForAgricultureResourcesClient, error)`
    info	[Changelog] - New function `*DataManagerForAgricultureResourcesClient.CreateOrUpdate(context.Context, string, string, DataManagerForAgriculture, *DataManagerForAgricultureResourcesClientCreateOrUpdateOptions) (DataManagerForAgricultureResourcesClientCreateOrUpdateResponse, error)`
    info	[Changelog] - New function `*DataManagerForAgricultureResourcesClient.Delete(context.Context, string, string, *DataManagerForAgricultureResourcesClientDeleteOptions) (DataManagerForAgricultureResourcesClientDeleteResponse, error)`
    info	[Changelog] - New function `*DataManagerForAgricultureResourcesClient.Get(context.Context, string, string, *DataManagerForAgricultureResourcesClientGetOptions) (DataManagerForAgricultureResourcesClientGetResponse, error)`
    info	[Changelog] - New function `*DataManagerForAgricultureResourcesClient.NewListByResourceGroupPager(string, *DataManagerForAgricultureResourcesClientListByResourceGroupOptions) *runtime.Pager[DataManagerForAgricultureResourcesClientListByResourceGroupResponse]`
    info	[Changelog] - New function `*DataManagerForAgricultureResourcesClient.NewListBySubscriptionPager(*DataManagerForAgricultureResourcesClientListBySubscriptionOptions) *runtime.Pager[DataManagerForAgricultureResourcesClientListBySubscriptionResponse]`
    info	[Changelog] - New function `*DataManagerForAgricultureResourcesClient.BeginUpdate(context.Context, string, string, DataManagerForAgricultureUpdateRequestModel, *DataManagerForAgricultureResourcesClientBeginUpdateOptions) (*runtime.Poller[DataManagerForAgricultureResourcesClientUpdateResponse], error)`
    info	[Changelog] - New function `*ExtensionsClient.CreateOrUpdate(context.Context, string, string, string, *ExtensionsClientCreateOrUpdateOptions) (ExtensionsClientCreateOrUpdateResponse, error)`
    info	[Changelog] - New function `*ExtensionsClient.NewListByDataManagerForAgriculturePager(string, string, *ExtensionsClientListByDataManagerForAgricultureOptions) *runtime.Pager[ExtensionsClientListByDataManagerForAgricultureResponse]`
    info	[Changelog] - New function `*OAuthClientCredentials.GetAuthCredentials() *AuthCredentials`
    info	[Changelog] - New function `NewOperationResultsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*OperationResultsClient, error)`
    info	[Changelog] - New function `*OperationResultsClient.Get(context.Context, string, string, *OperationResultsClientGetOptions) (OperationResultsClientGetResponse, error)`
    info	[Changelog] - New function `NewSolutionsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*SolutionsClient, error)`
    info	[Changelog] - New function `*SolutionsClient.CreateOrUpdate(context.Context, string, string, string, *SolutionsClientCreateOrUpdateOptions) (SolutionsClientCreateOrUpdateResponse, error)`
    info	[Changelog] - New function `*SolutionsClient.Delete(context.Context, string, string, string, *SolutionsClientDeleteOptions) (SolutionsClientDeleteResponse, error)`
    info	[Changelog] - New function `*SolutionsClient.Get(context.Context, string, string, string, *SolutionsClientGetOptions) (SolutionsClientGetResponse, error)`
    info	[Changelog] - New function `*SolutionsClient.NewListPager(string, string, *SolutionsClientListOptions) *runtime.Pager[SolutionsClientListResponse]`
    info	[Changelog] - New function `NewSolutionsDiscoverabilityClient(azcore.TokenCredential, *arm.ClientOptions) (*SolutionsDiscoverabilityClient, error)`
    info	[Changelog] - New function `*SolutionsDiscoverabilityClient.Get(context.Context, string, *SolutionsDiscoverabilityClientGetOptions) (SolutionsDiscoverabilityClientGetResponse, error)`
    info	[Changelog] - New function `*SolutionsDiscoverabilityClient.NewListPager(*SolutionsDiscoverabilityClientListOptions) *runtime.Pager[SolutionsDiscoverabilityClientListResponse]`
    info	[Changelog] - New struct `APIKeyAuthCredentials`
    info	[Changelog] - New struct `APIProperties`
    info	[Changelog] - New struct `ArmAsyncOperationError`
    info	[Changelog] - New struct `DataConnector`
    info	[Changelog] - New struct `DataConnectorListResponse`
    info	[Changelog] - New struct `DataConnectorProperties`
    info	[Changelog] - New struct `DataManagerForAgriculture`
    info	[Changelog] - New struct `DataManagerForAgricultureExtension`
    info	[Changelog] - New struct `DataManagerForAgricultureExtensionListResponse`
    info	[Changelog] - New struct `DataManagerForAgricultureExtensionProperties`
    info	[Changelog] - New struct `DataManagerForAgricultureListResponse`
    info	[Changelog] - New struct `DataManagerForAgricultureProperties`
    info	[Changelog] - New struct `DataManagerForAgricultureSolution`
    info	[Changelog] - New struct `DataManagerForAgricultureSolutionListResponse`
    info	[Changelog] - New struct `DataManagerForAgricultureSolutionProperties`
    info	[Changelog] - New struct `DataManagerForAgricultureUpdateProperties`
    info	[Changelog] - New struct `DataManagerForAgricultureUpdateRequestModel`
    info	[Changelog] - New struct `ExtensionInstallationRequest`
    info	[Changelog] - New struct `KeyVaultProperties`
    info	[Changelog] - New struct `MarketplaceOfferDetails`
    info	[Changelog] - New struct `OAuthClientCredentials`
    info	[Changelog] - New struct `Solution`
    info	[Changelog] - New struct `SolutionListResponse`
    info	[Changelog] - New struct `SolutionProperties`
    info	[Changelog] - New field `Error` in struct `ArmAsyncOperation`
    info	[Changelog] - New field `APIDefaultInputParameters`, `APIDocsLink`, `APIType` in struct `DetailedInformation`
    info	[Changelog] - New field `SkipToken` in struct `ExtensionListResponse`
    info	[Changelog] - New field `AdditionalAPIProperties` in struct `ExtensionProperties`
    info	[Changelog] - New field `GroupIDs` in struct `PrivateEndpointConnectionProperties`
    info	[Changelog]
    info	[Changelog] Total 38 breaking change(s), 98 additive change(s).
    Present SDK breaking changes suppressions
    No suppression file added.
    Absent SDK breaking changes suppressions
    - Function `*ClientFactory.NewFarmBeatsExtensionsClient` has been removed
    - Function `*ClientFactory.NewFarmBeatsModelsClient` has been removed
    - Function `*ClientFactory.NewLocationsClient` has been removed
    - Function `*ExtensionsClient.Create` has been removed
    - Function `*ExtensionsClient.NewListByFarmBeatsPager` has been removed
    - Function `*ExtensionsClient.Update` has been removed
    - Function `*FarmBeatsExtensionsClient.Get` has been removed
    - Function `*FarmBeatsExtensionsClient.NewListPager` has been removed
    - Function `*FarmBeatsModelsClient.BeginUpdate` has been removed
    - Function `*FarmBeatsModelsClient.CreateOrUpdate` has been removed
    - Function `*FarmBeatsModelsClient.Delete` has been removed
    - Function `*FarmBeatsModelsClient.GetOperationResult` has been removed
    - Function `*FarmBeatsModelsClient.Get` has been removed
    - Function `*FarmBeatsModelsClient.NewListByResourceGroupPager` has been removed
    - Function `*FarmBeatsModelsClient.NewListBySubscriptionPager` has been removed
    - Function `*LocationsClient.CheckNameAvailability` has been removed
    - Function `NewFarmBeatsExtensionsClient` has been removed
    - Function `NewFarmBeatsModelsClient` has been removed
    - Function `NewLocationsClient` has been removed
    - Operation `*PrivateEndpointConnectionsClient.NewListByResourcePager` does not support pagination anymore, use `*PrivateEndpointConnectionsClient.ListByResource` instead.
    - Operation `*PrivateLinkResourcesClient.NewListByResourcePager` does not support pagination anymore, use `*PrivateLinkResourcesClient.ListByResource` instead.
    - Struct `FarmBeatsExtensionListResponse` has been removed
    - Struct `FarmBeatsExtensionProperties` has been removed
    - Struct `FarmBeatsExtension` has been removed
    - Struct `FarmBeatsListResponse` has been removed
    - Struct `FarmBeatsProperties` has been removed
    - Struct `FarmBeatsUpdateProperties` has been removed
    - Struct `FarmBeatsUpdateRequestModel` has been removed
    - Struct `FarmBeats` has been removed
    - `PublicNetworkAccessHybrid` from enum `PublicNetworkAccess` has been removed
    Parse Suppression File Errors
    No suppression file added.
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️❌ azure-sdk-for-js failed [Detail]
  • Failed in generating from 9b754e98b388642b149baf217a80a212a7d6ab71. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    cmdout	[automation_generate.sh] Executing command:
    warn	Skip package processing as generation is failed
    error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 9b754e98b388642b149baf217a80a212a7d6ab71. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-agrifood [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-agrifood-1.0.0-beta.2.jar
    • azure-resourcemanager-agrifood-1.0.0-beta.2-sources.jar
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning in generating from 9b754e98b388642b149baf217a80a212a7d6ab71. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.agrifood.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app-test bot commented Apr 25, 2024

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
Compared specs (v0.10.8) new version base version
agfood.json 2020-05-12-preview(818e434) 2020-05-12-preview(main)
Rule Message
1008 - ModifiedOperationId The operation id has been changed from 'Extensions_Create' to 'Extensions_Create test test'. This will impact generated code.
New: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L10:7
Old: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L10:7
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.1) new version base version
package-2020-05-12-preview package-2020-05-12-preview(818e434) package-2020-05-12-preview(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
ResourceNameRestriction The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L9
ParametersOrder The parameters:extensionId,farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L10
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L10
ParametersOrder The parameters:extensionId,farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L56
ParametersOrder The parameters:extensionId,farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L102
ParametersOrder The parameters:extensionId,farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L148
ResourceNameRestriction The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L195
ResourceNameRestriction The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L466
ParametersOrder The parameters:farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L510
ParametersOrder The parameters:farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L571
UnSupportedPatchProperties Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L596
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:name.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L601
TopLevelResourcesListBySubscription The top-level resource 'FarmBeatsExtension' does not have list by subscription operation, please add it.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L1093
ProvisioningStateValidation ProvisioningState must have terminal states: Succeeded, Failed and Canceled.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L1167
⚠️ PreviewVersionOverOneYear The API version:2020-05-12-preview having been in a preview state over one year , please move it to GA or retire.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L6
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L27
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L30
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L33
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L46
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L73
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L76
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L79
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L92
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L119
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L122
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L125
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L138
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L165
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L168
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L171
️️✔️[ignore this check status; not blocking PR merge] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[ignore this check status; not blocking PR merge] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

@konrad-jamrozik
Copy link
Author

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants