forked from Azure/azure-rest-api-specs
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE][Internal testing] - testing FYI bot update - typespec req failure test 3 #3193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to mergeAddressing the following failures is highly recommended:
If you still want to proceed merging this PR without addressing the above failures, refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Generation Artifacts
|
Generated ApiView
|
Swagger Validation Report
|
Rule | Message |
---|---|
Runtime Exception |
"new":"https://github.com/test-repo-billy/azure-rest-api-specs/blob/51e469dffa6e69060b319e2a0f107a8e87bc6028/specification/agrifood/resource-manager/Microsoft.AgFoodPlatform/preview/2024-01-25-preview/agfood.json", "old":"https://github.com/test-repo-billy/azure-rest-api-specs/blob/main/specification/agrifood/resource-manager/Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json", "details":"Breaking change detector (OAD) invoked AutoRest. AutoRest threw a runtime error. First 6 lines of stack trace follow, indexed. First line should contain AutoRest command line invocation details. Second line should contain the main message reported by AutoRest. ==================== 1: Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidationTest_1a18ed4f-f3bf-4f34-9fed-13cb57bd2410/0.0.388/common/temp/node_modules/.pnpm/@Azure[email protected]/node_modules/autorest/dist/app.js" --v2 --input-file=specification/agrifood/resource-manager/Microsoft.AgFoodPlatform/preview/2024-01-25-preview/agfood.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp -------------------- 2: ERROR: Referenced file 'file:///mnt/vss/work/1/azure-rest-api-specs/specification/agrifood/resource-manager/Microsoft.AgFoodPlatform/preview/2024-01-25-preview/examples/SolutionsDiscoverabilityGet.json' not found -------------------- 3: - file:///mnt/vss/work/1/azure-rest-api-specs/specification/agrifood/resource-manager/Microsoft.AgFoodPlatform/preview/2024-01-25-preview/agfood.json:1866:12 ($.paths["/providers/Microsoft.AgFoodPlatform/farmBeatsSolutionDefinitions/dataManagerForAgricultureSolutionId"].get["x-ms-examples"].SolutionsDiscoverabilityGet["$ref"]) -------------------- 4: FATAL: swagger-document/loader - FAILED -------------------- 5: FATAL: Error: [OperationAbortedException] Error occurred. Exiting. -------------------- 6: Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting. --------------------" |
️❌
LintDiff: 1 Errors, 0 Warnings failed [Detail]
compared tags (via openapi-validator v2.1.6) | new version | base version |
---|---|---|
default | default(51e469d) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
FATAL |
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/agrifood/resource-manager/Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json'. Errors encountered: TypeError: Cannot read property 'additionalProperties' of null Location: azure-rest-api-specs/blob/51e469dffa6e69060b319e2a0f107a8e87bc6028/#L1 |
️️✔️
~[NotRequired_Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌
Avocado: 3 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
UNREFERENCED_JSON_FILE |
The swagger JSON file is not referenced from the readme file. readme: specification/agrifood/resource-manager/readme.md json: Microsoft.AgFoodPlatform/preview/2024-01-25-preview/agfood.json |
UNREFERENCED_JSON_FILE |
The example JSON file is not referenced from the swagger file. readme: specification/agrifood/resource-manager/readme.md json: preview/2024-01-25-preview/examples/CheckNameAvailability_CheckNameAvailability_AlreadyExists.json |
UNREFERENCED_JSON_FILE |
The example JSON file is not referenced from the swagger file. readme: specification/agrifood/resource-manager/readme.md json: preview/2024-01-25-preview/examples/CheckNameAvailability_CheckNameAvailability_Available.json |
️❌
ModelValidation: 2 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
unacceptable kind of an object to dump [object Error] |
"role":"Model Validation", "url":"https://github.com/test-repo-billy/azure-rest-api-specs/blob/51e469dffa6e69060b319e2a0f107a8e87bc6028/specification/agrifood/resource-manager/Microsoft.AgFoodPlatform/preview/2024-01-25-preview/agfood.json" |
unacceptable kind of an object to dump [object Error] |
"role":"Model Validation", "url":"https://github.com/test-repo-billy/azure-rest-api-specs/blob/51e469dffa6e69060b319e2a0f107a8e87bc6028/specification/agrifood/resource-manager/Microsoft.AgFoodPlatform/preview/2024-01-25-preview/agfood.json" |
️❌
SemanticValidation: 1 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
INTERNAL_ERROR |
Unexpected internal error: ENOENT: no such file or directory, open '/mnt/vss/_work/1/azure-rest-api-specs/specification/agrifood/resource-manager/Microsoft.AgFoodPlatform/preview/2024-01-25-preview/examples/DataConnectors_Get.json' Error: ENOENT: no such file or directory, open '/mnt/vss/_work/1/azure-rest-api-specs/specification/agrifood/resource-manager/Microsoft.AgFoodPlatform/preview/2024-01-25-preview/examples/DataConnectors_Get.json' JsonUrl: Microsoft.AgFoodPlatform/preview/2024-01-25-preview/agfood.json |
️❌
~[NotRequired_Staging] SpellCheck: 2 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
HowToFix |
Unknown word (MADMA), please fix the error. See https://aka.ms/ci-fix#spell-check path: Microsoft.AgFoodPlatform/preview/2024-01-25-preview/agfood.json#L120:61 |
HowToFix |
Unknown word (MADMA), please fix the error. See https://aka.ms/ci-fix#spell-check path: Microsoft.AgFoodPlatform/preview/2024-01-25-preview/agfood.json#L248:66 |
️️✔️
PR Summary succeeded [Detail] [Expand]
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Hi @konrad-jamrozik! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
konrad-jamrozik
added
Approved-LintDiff
WaitForARMFeedback
and removed
CI-BreakingChange-Python-Track2
labels
Jan 25, 2024
This was referenced Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR made by the Azure SDK Engineering System team
devdiv.visualstudio.com/DevDiv/_git/openapi-alps/pullrequest/523770