Added loadtesting tsp #3168
Open
Added loadtesting tsp #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update widgets.json
Update widgets.json
…sting Update widgets.json
…st-1 Update widgets.json
Testing assistant
…sistant Testing with spec change
* Rename bug.md to bug_report.md * Create config.yml
[Internal testing] testing openapi-alps PR 510778 - Test 11/14/2023 / 1
[Internal testing] testing openapi-alps PR 510778 - Test 11/14/2023 / 2
[Internal testing] testing openapi-alps PR 510778 - Test 11/15/2023 / 1
[Internal testing] testing openapi-alps PR 511346 - Test 1
Swagger Generation Artifacts
|
Generated ApiView
|
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| loadtestservice.json | 2022-11-01(bd17a55) | 2022-11-01(main) |
Only 17 items are listed, please refer to log for more details.
️❌Breaking Change(Cross-Version): 159 Errors, 141 Warnings failed [Detail]
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| loadtestservice.json | 2023-04-01-preview(bd17a55) | 2022-11-01(main) |
| loadtestservice.json | 2023-04-01-preview(bd17a55) | 2022-06-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 17 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with latest preview version:
Only 17 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/appcomponents/{name}' removed or restructured? Old: Microsoft.LoadTestService/preview/2022-06-01-preview/loadtestservice.json#L22:5 |
|
| The new version is missing a path that was found in the old version. Was path '/appcomponents' removed or restructured? Old: Microsoft.LoadTestService/preview/2022-06-01-preview/loadtestservice.json#L189:5 |
|
| The new version is missing a path that was found in the old version. Was path '/serverMetricsConfig/{name}' removed or restructured? Old: Microsoft.LoadTestService/preview/2022-06-01-preview/loadtestservice.json#L243:5 |
|
| The new version is missing a path that was found in the old version. Was path '/serverMetricsConfig' removed or restructured? Old: Microsoft.LoadTestService/preview/2022-06-01-preview/loadtestservice.json#L410:5 |
|
| The new version is missing a path that was found in the old version. Was path '/serverMetricsConfig/default' removed or restructured? Old: Microsoft.LoadTestService/preview/2022-06-01-preview/loadtestservice.json#L464:5 |
|
| The new version is missing a path that was found in the old version. Was path '/serverMetricsConfig/supportedResourceTypes' removed or restructured? Old: Microsoft.LoadTestService/preview/2022-06-01-preview/loadtestservice.json#L506:5 |
|
| The new version is missing a path that was found in the old version. Was path '/loadtests/{testId}' removed or restructured? Old: Microsoft.LoadTestService/preview/2022-06-01-preview/loadtestservice.json#L548:5 |
|
| The new version is missing a path that was found in the old version. Was path '/loadtests/sortAndFilter' removed or restructured? Old: Microsoft.LoadTestService/preview/2022-06-01-preview/loadtestservice.json#L694:5 |
|
| The new version is missing a path that was found in the old version. Was path '/loadtests/{testId}/files/{fileId}' removed or restructured? Old: Microsoft.LoadTestService/preview/2022-06-01-preview/loadtestservice.json#L779:5 |
|
| The new version is missing a path that was found in the old version. Was path '/loadtests/{testId}/files' removed or restructured? Old: Microsoft.LoadTestService/preview/2022-06-01-preview/loadtestservice.json#L954:5 |
|
| The new version is missing a path that was found in the old version. Was path '/testruns/{testRunId}' removed or restructured? Old: Microsoft.LoadTestService/preview/2022-06-01-preview/loadtestservice.json#L1008:5 |
|
| The new version is missing a path that was found in the old version. Was path '/testruns/{testRunId}/files/{fileId}' removed or restructured? Old: Microsoft.LoadTestService/preview/2022-06-01-preview/loadtestservice.json#L1175:5 |
|
| The new version is missing a path that was found in the old version. Was path '/testruns/sortAndFilter' removed or restructured? Old: Microsoft.LoadTestService/preview/2022-06-01-preview/loadtestservice.json#L1237:5 |
|
| The new version is missing a path that was found in the old version. Was path '/testruns/{testRunId}:stop' removed or restructured? Old: Microsoft.LoadTestService/preview/2022-06-01-preview/loadtestservice.json#L1331:5 |
|
| The new version is missing a path that was found in the old version. Was path '/testruns/{testRunId}/clientMetrics' removed or restructured? Old: Microsoft.LoadTestService/preview/2022-06-01-preview/loadtestservice.json#L1383:5 |
|
| The new version is missing a path that was found in the old version. Was path '/testruns/{testRunId}/clientMetricsFilters' removed or restructured? Old: Microsoft.LoadTestService/preview/2022-06-01-preview/loadtestservice.json#L1447:5 |
|
| The new version is missing a definition that was found in the old version. Was 'AppComponentsMap' removed or renamed? New: Microsoft.LoadTestService/preview/2023-04-01-preview/loadtestservice.json#L1614:3 Old: Microsoft.LoadTestService/preview/2022-06-01-preview/loadtestservice.json#L1500:3 |
️⚠️LintDiff: 82 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.6) | new version | base version |
|---|---|---|
| package-2022-11-01 | package-2022-11-01(bd17a55) | package-2022-11-01(main) |
| package-2023-04-01-preview | package-2023-04-01-preview(bd17a55) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 17 items are listed, please refer to log for more details.
The following errors/warnings exist before current PR submission:
Only 17 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| 'PATCH' operation 'LoadTestRun_CreateOrUpdateTestRun' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.LoadTestService/preview/2023-04-01-preview/loadtestservice.json#L175 |
|
| 'PATCH' operation 'LoadTestRun_CreateOrUpdateAppComponents' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.LoadTestService/preview/2023-04-01-preview/loadtestservice.json#L390 |
|
| Based on the response model schema, operation 'LoadTestRun_ListMetricDefinitions' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.LoadTestService/preview/2023-04-01-preview/loadtestservice.json#L514 |
|
| Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.LoadTestService/preview/2023-04-01-preview/loadtestservice.json#L514 |
|
| Based on the response model schema, operation 'LoadTestRun_ListMetricNamespaces' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.LoadTestService/preview/2023-04-01-preview/loadtestservice.json#L640 |
|
| Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.LoadTestService/preview/2023-04-01-preview/loadtestservice.json#L640 |
|
| 'PATCH' operation 'LoadTestRun_CreateOrUpdateServerMetricsConfig' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.LoadTestService/preview/2023-04-01-preview/loadtestservice.json#L820 |
|
| 'PATCH' operation 'LoadTestAdministration_CreateOrUpdateTest' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.LoadTestService/preview/2023-04-01-preview/loadtestservice.json#L994 |
|
| 'PATCH' operation 'LoadTestAdministration_CreateOrUpdateAppComponents' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.LoadTestService/preview/2023-04-01-preview/loadtestservice.json#L1156 |
|
| A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'LoadTestAdministration_UploadTestFile' Request Model: 'parameters[4].schema' Response Model: 'responses[201].schema' Location: Microsoft.LoadTestService/preview/2023-04-01-preview/loadtestservice.json#L1331 |
|
| OperationId for put method should contain 'Create' Location: Microsoft.LoadTestService/preview/2023-04-01-preview/loadtestservice.json#L1332 |
|
| 'PUT' operation 'LoadTestAdministration_UploadTestFile' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.LoadTestService/preview/2023-04-01-preview/loadtestservice.json#L1332 |
|
| 'PATCH' operation 'LoadTestAdministration_CreateOrUpdateServerMetricsConfig' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.LoadTestService/preview/2023-04-01-preview/loadtestservice.json#L1547 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.LoadTestService/preview/2023-04-01-preview/loadtestservice.json#L2027 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.LoadTestService/preview/2023-04-01-preview/loadtestservice.json#L2032 |
|
| 'PATCH' operation 'LoadTestRun_CreateOrUpdateTestRun' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.LoadTestService/stable/2022-11-01/loadtestservice.json#L175 |
|
| 'PATCH' operation 'LoadTestRun_CreateOrUpdateAppComponents' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.LoadTestService/stable/2022-11-01/loadtestservice.json#L390 |
️️✔️~[NotRequired_Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️~[NotRequired_Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
|
Hi @raych1! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
This was referenced Dec 26, 2023
Closed
Closed
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
konrad-jamrozik
force-pushed
the
main
branch
from
6f9f31c to
d8e7a99
Compare
raych1
requested review from
weshaggard,
mikeharder and
konrad-jamrozik
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing sdk generation