chore: Fix tests, remove EOL OSes, fix Ruby 3.4 compatibility warnings #421
Conversation
Signed-off-by: Andrew Bobulsky <[email protected]>
RulerOf
changed the title
| driver: | ||
| image: opensuse/leap:15 |
There was a problem hiding this comment.
This slug should get you the latest without having to maintain the version here
There was a problem hiding this comment.
I ended up putting in the two versions separately because both of them showed to still be under active support on the website.
There was a problem hiding this comment.
Oh wait I see what you mean. Specify a "latest v15" in addition to a "specific v15."
There was a problem hiding this comment.
Leap:15 should always be the latest
Signed-off-by: Andrew Bobulsky <[email protected]>
Ruby is removing some gems from the standard library. Require them explicitly. Signed-off-by: Andrew Bobulsky <[email protected]>
Development group gems resolved an old version of inspec on my machine, and would throw an ugly warning. Bump the minimum inspec version to resolve that. Signed-off-by: Andrew Bobulsky <[email protected]>
CentOS 7 is EOL. Stop testing it, and switch to a similar release. Signed-off-by: Andrew Bobulsky <[email protected]>
Chef is not supported on every OS that kitchen-docker supports, so it doesn't really make sense to install it here. Also Dokken is a thing. Signed-off-by: Andrew Bobulsky <[email protected]>
The default busser verifier literally refuses to work, and the 1-test inspec is simple enough to work on everything. Signed-off-by: Andrew Bobulsky <[email protected]>
Bundler shims and rubymine folder Signed-off-by: Andrew Bobulsky <[email protected]>
CentOS 7, Ubuntu 18, Rocky 8, Debian 11 are all EOL. Signed-off-by: Andrew Bobulsky <[email protected]>
Signed-off-by: Andrew Bobulsky <[email protected]>
Signed-off-by: Andrew Bobulsky <[email protected]>
| @@ -1,4 +1,4 @@ | |||
| FROM centos:7 | |||
| FROM oraclelinux:7 | |||
There was a problem hiding this comment.
in the kitchen-dokken driver we switched to almalinux-9. Should probably do the same here for consistency and future proofing. Then the yum commands can be updated to dnf.
There was a problem hiding this comment.
I updated the Dockerfile and got it building successfully, but kitchen-docker complains the container isn't listening for ssh connections.
Perhaps I need to change the CMD to run the ssh server? It wasn't obvious to me why it worked with Oracle 7 but not Alma 9.
Signed-off-by: Corey Hemminger <[email protected]> Signed-off-by: Andrew Bobulsky <[email protected]> add codeowners Signed-off-by: Corey Hemminger <[email protected]> test Signed-off-by: Corey Hemminger <[email protected]> test Signed-off-by: Corey Hemminger <[email protected]> test Signed-off-by: Corey Hemminger <[email protected]>
Everything is already testing with Inspec Signed-off-by: Andrew Bobulsky <[email protected]>
The verifier doesn't work without it. Not sure why it was removed, but I know base PR was ongoing. Signed-off-by: Andrew Bobulsky <[email protected]>
Add a step to the github action that uses an embedded ruby script to discover the list of suites directly from the kitchen config. Signed-off-by: Andrew Bobulsky <[email protected]>
Do this instead of testing 15.5 and 15.6 explicitly Signed-off-by: Andrew Bobulsky <[email protected]>
Signed-off-by: Andrew Bobulsky <[email protected]>
Current versions of Docker Desktop will output a LegacyKeyValueFormat warning when using 'ENV key value' syntax. We switch to the updated 'ENV key=value' syntax. Signed-off-by: Andrew Bobulsky <[email protected]>
Description
Most of the tests were broken.
Issues Resolved
I didn't create any, but this will fix the broken tests on #420
Type of Change
chore
Check List