Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terrarium - Providers]: Fix empty structs #73

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Conversation

anjanikshree12
Copy link
Contributor

@anjanikshree12 anjanikshree12 commented May 1, 2024

Problem:

  • Found a small bug, On registration of providers, we are not yet publishing it, but although being empty, published_on field used to get added in the table as an attribute of an item having empty value, which should not happen until we publish it actually.
  • Same for modified_on too.

Solution:

  • Added omit_empty in the Struct tags which would avoid the structs to be added as an attribute in the table when it's empty as they get omitted.

@anjanikshree12 anjanikshree12 requested a review from adcharre June 13, 2024 15:54
@anjanikshree12 anjanikshree12 merged commit 05d66ba into main Jun 18, 2024
1 check passed
@anjanikshree12 anjanikshree12 deleted the fix-empty-structs branch June 18, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants