-
Notifications
You must be signed in to change notification settings - Fork 369
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: make project_id as required input and update apphub_workload_uri…
… output
- Loading branch information
Showing
11 changed files
with
49 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
# Upgrading to MIG v13.0 | ||
|
||
The v13.0 release of MIG is a backwards incompatible release. Now the `project_id` is required input variable. Earlier it was set to `null` by default. But the `terraform plan` would fail because `google_compute_zones` data block requires a non-null `project_id`. | ||
Users might be bypassing this by setting project at provider level and not providing `project_id` for mig module. | ||
|
||
## Migration Instructions | ||
|
||
### Explicitly provide project_id as input to the MIG module | ||
|
||
Users would need to provide project_id explicitly while using v13.0 of mig/mig_with_percent. | ||
|
||
For mig, | ||
|
||
```diff | ||
module "mig" { | ||
source = "terraform-google-modules/vm/google//modules/mig" | ||
version = "~> 12.0" | ||
|
||
+ project_id = var.project_id | ||
region = var.region | ||
target_size = var.target_size | ||
hostname = "mig-simple" | ||
instance_template = module.instance_template.self_link | ||
} | ||
``` | ||
|
||
For mig_with_percent, | ||
|
||
```diff | ||
module "mig_with_percent" { | ||
source = "terraform-google-modules/vm/google//modules/mig_with_percent" | ||
version = "~> 12.0" | ||
|
||
+ project_id = var.project_id | ||
region = var.region | ||
target_size = 4 | ||
hostname = "mig-with-percent-simple" | ||
instance_template_initial_version = module.preemptible_and_regular_instance_templates.regular_self_link | ||
instance_template_next_version = module.preemptible_and_regular_instance_templates.preemptible_self_link | ||
next_version_percent = 50 | ||
} | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters