-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix apphub uri and id representation #360
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjy9206
changed the title
chore: improve apphub uri extraction logic
chore: Fix apphub uri and id representation
Oct 21, 2024
tjy9206
changed the title
chore: Fix apphub uri and id representation
fix: Fix apphub uri and id representation
Oct 23, 2024
q2w
reviewed
Oct 23, 2024
q2w
reviewed
Oct 25, 2024
/gcbrun |
/gcbrun |
/gcbrun |
q2w
reviewed
Oct 28, 2024
auto-merge was automatically disabled
October 28, 2024 13:57
Head branch was pushed to by a user without write access
q2w
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource representation for GCS buckets should be
//storage.googleapis.com/<bucket-name>
.Also improved the logic of id generation.