Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix apphub uri and id representation #360

Merged
merged 8 commits into from
Oct 28, 2024

Conversation

tjy9206
Copy link
Contributor

@tjy9206 tjy9206 commented Oct 21, 2024

Resource representation for GCS buckets should be //storage.googleapis.com/<bucket-name>.

Also improved the logic of id generation.

@tjy9206 tjy9206 requested review from q2w and a team as code owners October 21, 2024 22:58
@tjy9206 tjy9206 changed the title chore: improve apphub uri extraction logic chore: Fix apphub uri and id representation Oct 21, 2024
@tjy9206 tjy9206 changed the title chore: Fix apphub uri and id representation fix: Fix apphub uri and id representation Oct 23, 2024
outputs.tf Show resolved Hide resolved
modules/simple_bucket/outputs.tf Outdated Show resolved Hide resolved
modules/simple_bucket/outputs.tf Outdated Show resolved Hide resolved
@q2w
Copy link
Collaborator

q2w commented Oct 25, 2024

/gcbrun

@q2w
Copy link
Collaborator

q2w commented Oct 25, 2024

/gcbrun

@q2w q2w enabled auto-merge (squash) October 25, 2024 21:18
@tjy9206
Copy link
Contributor Author

tjy9206 commented Oct 26, 2024

/gcbrun

@tjy9206 tjy9206 requested a review from q2w October 28, 2024 13:47
auto-merge was automatically disabled October 28, 2024 13:57

Head branch was pushed to by a user without write access

@q2w q2w enabled auto-merge (squash) October 28, 2024 14:04
@tjy9206 tjy9206 requested a review from q2w October 28, 2024 14:34
@q2w q2w merged commit 2782340 into terraform-google-modules:master Oct 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants