Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update example to match default pluginAdminEnabled = false to remove from diff #28

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

rlanore
Copy link
Contributor

@rlanore rlanore commented Nov 29, 2023

Description

Add new AMG parameter

Motivation and Context

To skip update in-place on every tf apply

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have executed pre-commit run -a on my pull request

To skip update in-place on every tf apply
@rlanore rlanore changed the title Example update with new plugin management to false Fix example update with new plugin management to false Nov 29, 2023
@rlanore rlanore changed the title Fix example update with new plugin management to false fix: update example with new plugin management to false Nov 29, 2023
@rlanore rlanore changed the title fix: update example with new plugin management to false fix: Update example with new plugin management to false Nov 29, 2023
@bryantbiggs
Copy link
Member

can you share more details on this change - why its warranted, what problems/issues it solves, what its demonstrating, ?

@rlanore
Copy link
Contributor Author

rlanore commented Nov 30, 2023

With your example file after the first apply every next terraform apply want to update grafana workspace

 # module.managed_grafana.aws_grafana_workspace.this[0] will be updated in-place
  ~ resource "aws_grafana_workspace" "this" {
      ~ configuration             = jsonencode(
          ~ {
              - plugins         = {
                  - pluginAdminEnabled = false
                }
                # (1 unchanged attribute hidden)
            }
        )
        id                        = "g-xxxxxxxxx"
        name                      = "foo"
        tags                      = {}
        # (13 unchanged attributes hidden)
    }

This PR is to add this new attributes to terraform apply correctly like:

No changes. Your infrastructure matches the configuration.

@bryantbiggs bryantbiggs changed the title fix: Update example with new plugin management to false docs: Update example to match default pluginAdminEnabled = false to remove from diff Nov 30, 2023
@bryantbiggs bryantbiggs merged commit 2bc6d50 into terraform-aws-modules:master Nov 30, 2023
8 of 13 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2023
@antonbabenko
Copy link
Member

This PR is included in version 2.1.1 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants