Implement Tax 1.2% in all transactions

[vegasmorph]

Implement part of the on chain proposal 3568

[vegasmorph]

[{
“subspace”: “treasury”,
“key”: “tax_rate”,
“value”: “1.200000000000000000”
},
{
“subspace”: “distribution”,
“key”: “terra1sk06e3dyexuq4shw77y3dsv480xv42mq73anxu”,
“value”: “1.20000000000000000”
},
]

[octalmage]

This random file wouldn't be the right place for this. This needs to go in a new param change proposal.

[littlekira01]

I think the solution can be found here: https://classic-docs.terra.money/docs/develop/module-specifications/spec-treasury.html#k-updatetaxpolicy

[vegasmorph]

Tks cool

…

On Sat, 11 Jun 2022, 01:21 littlekira01, ***@***.***> wrote: I think the solution can be found here: https://classic-docs.terra.money/docs/develop/module-specifications/spec-treasury.html#k-updatetaxpolicy — Reply to this email directly, view it on GitHub <#102 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYWGC3YSWTM3ZS3HREJTLWDVOPLYNANCNFSM5YEEQUTQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[benjamin-koenig]

I hope you don't mind that I comment on this but these are non-standard double quotes.
Instead of “ shouldn't these be "?

[sann1432]

Looking good

[vegasmorph]

A bola está no lado dela agora...a única coisa que precisamos é de fazer pressão

…

On Sat, 11 Jun 2022, 22:59 luncbrasil, ***@***.***> wrote: eu não entend, a proposta já não estava definida para todas as transações? se não, como faram a mudança para atualizar é só alterar ou precisa fazer todo o processo de votação novamente? to confuso? — Reply to this email directly, view it on GitHub <#102 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYWGC33KWFZAD4IKIIZP6PDVOUD25ANCNFSM5YEEQUTQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[holylance]

@octalmage Can you merge this PR?
Or should we wait?

[octalmage]

It’s unfortunately invalid and not how param change proposals work.

[octalmage]

See this comment: #102 (comment)

[holylance]

@octalmage Thank you to answer quickly.
I am an Android developer, so I am not familiar with this terra classic repository.
Please understand. But I would like to add this tax system asap.

I think there are two possible options.

1. You mentioned "a new param change proposal".
   Does it mean that if I make a file like this in the new param change proposal directory, is it enough?

2. I heard that the tax 1.2 is not a parameter proposal, so one of the TFL developers has to "code" in somewhere in this repository.
   Is it correct? If it is, we have to wait until the developer completes this.

[octalmage]

@holylance No problem!

1. This is the wrong repository really. This just contains instructions for joining the network, but not any actual code. So no changes to this repo are needed. param change proposals are an on-chain system to allow you to modify different core parameters. You can see this example where LUNA stakers voted to set the stablecoin tax to zero: https://station.terra.money/proposal/172

This tax rate only effects Terra stablecoins though, and not Luna as can be seen here: https://github.com/terra-money/classic-core/blob/d6037b9a12c8bf6b09fe861c8ad93456aac5eebb/custom/auth/ante/tax.go#L154

2. So based on the above info if the desired result is to set a 1.2% tax on Luna, that will have to be new code. To say that only TFL devs can make this change is incorrect, the code is all open source and anyone can submit a pull request here: https://github.com/terra-money/classic-core

So one process that could work is to have someone write and test the code, submit as a pull request, then have it reviewed. Once reviewed and merged, you'll need to start a SoftwareUpgradeProposal which you can learn about here: https://docs.cosmos.network/master/modules/gov/01_concepts.html#software-upgrade

[holylance]

@holylance No problem!

1. This is the wrong repository really. This just contains instructions for joining the network, but not any actual code. So no changes to this repo are needed. param change proposals are an on-chain system to allow you to modify different core parameters. You can see this example where LUNA stakers voted to set the stablecoin tax to zero: https://station.terra.money/proposal/172

This tax rate only effects Terra stablecoins though, and not Luna as can be seen here: https://github.com/terra-money/classic-core/blob/d6037b9a12c8bf6b09fe861c8ad93456aac5eebb/custom/auth/ante/tax.go#L154

2. So based on the above info if the desired result is to set a 1.2% tax on Luna, that will have to be new code. To say that only TFL devs can make this change is incorrect, the code is all open source and anyone can submit a pull request here: https://github.com/terra-money/classic-core

So one process that could work is to have someone write and test the code, submit as a pull request, then have it reviewed. Once reviewed and merged, you'll need to start a SoftwareUpgradeProposal which you can learn about here: https://docs.cosmos.network/master/modules/gov/01_concepts.html#software-upgrade

Very Thanks :>

[jamesbsbs]

@octalmage thanks for your answers
so if @vegasmorph proposes a code that works ,
will you merge the pull request (or will terra team merge it) , or is it a waist of time ( this is not sarcasm, i'm serious).

thanks in advance

[vegasmorph]

this can only be implemented after the code is merged,not before
{
"title": "Param Change Policy",
"description": "Update tax policy",
"changes": [
{
"subspace": "treasury",
"key": "TaxPolicy",
"value": {"rate_min": "0.012", "rate_max": "0.012",
"cap":{"denom": "usdr", "amount": "10000000" },
"change_rate_max": "0.0"}
},
{
"subspace": "treasury",
"key": "RewardPolicy",
"value": {"rate_min": "1.0", "rate_max": "1.0",
"cap":{"denom": "unused", "amount": "0" },
"change_rate_max": "0.0"}
}
],
}