Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(main/libuv): Check for TERMUX_EXEC__PROC_SELF_EXE #20767

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fornwall
Copy link
Member

@fornwall fornwall commented Jul 2, 2024

This fixes running e.g. neovim under termux-exec with updated targetSdk.

Brief summary: When running with targetSdk to 28 or higher, it's not allowed to execute downloaded files (files not part of the APK in general) directly.

The termux-exec workaround using LD_PRELOAD that is currently used in the Google Play build instead executes e.g. /system/bin/linker64 $PREFIX/bin/nvim instead of $PREFIX/bin/nvim directly. One consequence of that is that reading /proc/self/exe to get the path to the currently running executable does not work, so patches like these (that should be a no-op when not running under bumped targetSdk and termux-exec) are necessary.

This fixes running e.g. neovim under `termux-exec` with updated
`targetSdk`.
@fornwall
Copy link
Member Author

fornwall commented Jul 2, 2024

I've raised the question in the termux/dev chat, if we want to start merging these kind of patches to prepare for this repository serving both targetSdk<29 and targetSdk>=29 builds.

@Grimler91
Copy link
Member

Before merging these type of PRs we should land termux/termux-exec#24 and #18872. Will look at it again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants