Fixed: Implement colon separated CSI parameters #4154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Colon separated escape sequences for setting colors
It seems that more and more terminal emulators and terminal programs supports colon (
:
) as well as semicolon (;
) to specify colors:See https://github.com/termstandard/colors?tab=readme-ov-file#truecolor-support-in-output-devices, where it can be seen that multiple terminal emulators also support using a colon as delimiter nowadays:
[..]
This is now implemented in Termux as well. Fixes termux/termux-packages#20655, escape sequence issues with
vtm
.See alacritty/vte#22 for a discussion when this was implemented in
alacritty/vte
.Colored and styled underlines parsing
We also here start to parse Colored and styled underlines as initially proposed by Kitty:
In this initial step we currently don't support straight/double/curly/dotted/dashed nor colored underlines, but parse them and map them to normal underlines. Fixes termux/termux-packages#20620, escape sequences showing up at the start of neovim. Future follow up work is actually respecting them when rendering, which is (at least IMHO) a nice touch when using code editors with support for it such as neovim.