Id, language pid and language column not translated

[dmolineus]

Right now the id, langPid and langColumn doesn't get translated by default which causes several issues:

• It's not possible to determinate the language from an loaded model
• It's not possible to determinate the real id of an loaded model
• Saving a loaded model would override the fallback language

So this pull request always handles such columns as translated columns.

Furthermore it addresses an issue in the getAlias method which uses the actual id and not getLanguageId().

[dmolineus]

I use the hardcoded id column here because it's already hardcoded, f.e. https://github.com/terminal42/contao-DC_Multilingual/pull/61/files#diff-56e9eeb0a83d5059b7bccbea1878371bR133

[qzminski]

Thank you for this pull request!

I think this might be a BC break as I am pretty sure there are some extensions which rely on those column values, so merging it in the current state is not possible IMO. We would have to get rid of id and pidColumn from columns that will be translated.

It's not possible to determinate the language from an loaded model

That could be an issue indeed and we should fetch language from the model 👍🏻

It's not possible to determinate the real id of an loaded model

I think this could be done using Multilingual::getLanguageId() no?

Saving a loaded model would override the fallback language

Isn't a multilingual model always prevented from saving?

contao-DC_Multilingual/src/Model/Multilingual.php

Line 221 in bbee4ad

$model->preventSaving(false);

The current concept of a multilingual model is that it is not a real-data model but is a combination of the fallback record + language record, so by any means it should not be saved. If you would like to update the language record itself, you would have to fetch it using findByPk($model->getLanguageId()) and then save it.

/cc @aschempp @Toflar

[dmolineus]

I think this might be a BC break as I am pretty sure there are some extensions which rely on those column values, so merging it in the current state is not possible IMO. We would have to get rid of id and pidColumn from columns that will be translated.

It depends on what is the intended purpose/design of the model, but I'd understand if you see it as a BC break. As a workaround I marked this fields as translatable.

It's not possible to determinate the real id of an loaded model

I think this could be done using Multilingual::getLanguageId() no?

No, it's not and that's why I think the current implementation is broken.

Multilingual::getLanguageId() would get the language pid if it's not 0, but within the current implementation it is always 0. The columns id, langPid and language always have the value of the fallback version of the model.

contao-DC_Multilingual/src/Model/Multilingual.php

Lines 26 to 35 in 8fef15a

	public function getLanguageId()
	{
	$pidColumn = static::getPidColumn();
	if ($this->{$pidColumn} > 0) {
	return $this->{$pidColumn};
	}
	return $this->id;
	}

Isn't a multilingual model always prevented from saving?

Sorry, you're right. Missed that.

[qzminski]

After a quick internal discussion we are good to merge it into 4.0.1. Thank you David!

[dmolineus]

Thanks your the quick release.

[aschempp]

Unfortunately, @qzminski was right with the initial assumption that this would be a BC break, see #69

I can't remember being part of that "internal discussion", any idea what that was about?

[qzminski]

Well, we probably discussed it on Skype, but as that was one year ago I am unable to find any relevant information. Probably I just sent this link and everyone agreed it should be merged 🤷🏻‍♂️

I think we should ignore that previous discussion anyway and approach this again with a fresh look.