Refactor module builder and fix issue 41 #87
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41 by adding
-vhlo-to-version
pass before-vhlo-legalize-to-stablehlo
in order to update VHLO to latest version. That converts v1 ops to v2 ops, and then-vhlo-legalize-to-stablehlo
successfully convertsvhlo.dot_general_v2
.Refactored module builder in the process:
api_impl.cc::ClientInstance::Compile
function