Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PJRT plugin attributes for StableHLO version #106

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Add PJRT plugin attributes for StableHLO version #106

merged 1 commit into from
Dec 10, 2024

Conversation

mrakitaTT
Copy link
Contributor

Fixes #97

@mrakitaTT mrakitaTT mentioned this pull request Dec 7, 2024
Closed
GleasonK
GleasonK reviewed Dec 7, 2024
View reviewed changes
Copy link

@GleasonK GleasonK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Reviewed from phone but names and data types look correct, and use of deserialize pipeline looks right.

@mrakitaTT mrakitaTT merged commit 5fd6cc8 into main Dec 10, 2024
6 checks passed
@mrakitaTT mrakitaTT deleted the mrakita/issue_97 branch December 10, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GleasonK GleasonK GleasonK left review comments

@ajakovljevicTT ajakovljevicTT ajakovljevicTT approved these changes

@kmitrovicTT kmitrovicTT Awaiting requested review from kmitrovicTT kmitrovicTT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PJRT attribute for StableHLO version to tt-xla plugin
3 participants
@mrakitaTT @GleasonK @ajakovljevicTT